Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flashing dot artifacts on the clouds #41

Open
shotamatsuda opened this issue Mar 7, 2025 · 2 comments
Open

Flashing dot artifacts on the clouds #41

shotamatsuda opened this issue Mar 7, 2025 · 2 comments
Labels
package: clouds Specific to @takram/three-clouds

Comments

@shotamatsuda
Copy link
Member

There may be cases where radiance being negative.

Image
@shotamatsuda shotamatsuda added the package: clouds Specific to @takram/three-clouds label Mar 7, 2025
@shotamatsuda
Copy link
Member Author

shotamatsuda commented Mar 10, 2025 •
edited
Loading

It seems this artifact was introduced when we reduced the floating-point precision of the precomputed texture #32. Rolling them back to FP32 resolves this issue...

@shotamatsuda
Copy link
Member Author

Using the FP32 internal format with FP16 precomputed textures also resolves it, suggesting more of a precision issue of linear interpolation. Such change will triage, but need to handle mobile devices separately where FP32 linear interpolation isn’t supported.

@shotamatsuda shotamatsuda changed the title Flashing dot artifacts on Safari Flashing dot artifacts on the clouds Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: clouds Specific to @takram/three-clouds
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shotamatsuda