Skip to content

Commit

Permalink
Change Chrome target to 111 (#15389)
Browse files Browse the repository at this point in the history
Resolves #15387

This PR changes the Chrome target to 111. We initially picked 120
because of the unnecessary `:dir()` down-leveling but we that was maybe
a bit too recent as it was causing some necessary prefixes to not be
generated (e.g. `-webkit-background-clip`).

This PR changes it to 111 which we require for the `color-mix()`
function. To work around the `:dir()` down-leveling we also disable the
`DirSelector` lightningcss feature which is used to control this
behavior:
https://sourcegraph.com/github.com/parcel-bundler/lightningcss/-/blob/src/selector.rs?L1964-1965
  • Loading branch information
philipp-spiess authored Dec 13, 2024
1 parent 4277857 commit 04dcf27
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fix missing `shadow-none` suggestion in IntelliSense ([#15342](https://github.com/tailwindlabs/tailwindcss/pull/15342))
- Optimize AST before printing for IntelliSense ([#15347](https://github.com/tailwindlabs/tailwindcss/pull/15347))
- Improve debug logs to get better insights ([#15303](https://github.com/tailwindlabs/tailwindcss/pull/15303))
- Generate vendor prefixes for Chrome features trialed between 111 and 119. ([#15389](https://github.com/tailwindlabs/tailwindcss/pull/15389))

### Changed

Expand Down
4 changes: 2 additions & 2 deletions packages/@tailwindcss-cli/src/commands/build/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -445,12 +445,12 @@ function optimizeCss(
deepSelectorCombinator: true,
},
include: Features.Nesting,
exclude: Features.LogicalProperties,
exclude: Features.LogicalProperties | Features.DirSelector,
targets: {
safari: (16 << 16) | (4 << 8),
ios_saf: (16 << 16) | (4 << 8),
firefox: 128 << 16,
chrome: 120 << 16,
chrome: 111 << 16,
},
errorRecovery: true,
}).code
Expand Down
4 changes: 2 additions & 2 deletions packages/@tailwindcss-postcss/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -317,12 +317,12 @@ function optimizeCss(
deepSelectorCombinator: true,
},
include: LightningCssFeatures.Nesting,
exclude: LightningCssFeatures.LogicalProperties,
exclude: LightningCssFeatures.LogicalProperties | LightningCssFeatures.DirSelector,
targets: {
safari: (16 << 16) | (4 << 8),
ios_saf: (16 << 16) | (4 << 8),
firefox: 128 << 16,
chrome: 120 << 16,
chrome: 111 << 16,
},
errorRecovery: true,
}).code
Expand Down
4 changes: 2 additions & 2 deletions packages/@tailwindcss-vite/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -375,12 +375,12 @@ function optimizeCss(
deepSelectorCombinator: true,
},
include: LightningCssFeatures.Nesting,
exclude: LightningCssFeatures.LogicalProperties,
exclude: LightningCssFeatures.LogicalProperties | LightningCssFeatures.DirSelector,
targets: {
safari: (16 << 16) | (4 << 8),
ios_saf: (16 << 16) | (4 << 8),
firefox: 128 << 16,
chrome: 120 << 16,
chrome: 111 << 16,
},
errorRecovery: true,
}).code
Expand Down
4 changes: 2 additions & 2 deletions packages/tailwindcss/src/test-utils/run.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ export function optimizeCss(
deepSelectorCombinator: true,
},
include: Features.Nesting,
exclude: Features.LogicalProperties,
exclude: Features.LogicalProperties | Features.DirSelector,
targets: {
safari: (16 << 16) | (4 << 8),
ios_saf: (16 << 16) | (4 << 8),
firefox: 128 << 16,
chrome: 120 << 16,
chrome: 111 << 16,
},
errorRecovery: true,
}).code
Expand Down
1 change: 1 addition & 0 deletions packages/tailwindcss/src/utilities.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11825,6 +11825,7 @@ test('bg-clip', async () => {
}
.bg-clip-text {
-webkit-background-clip: text;
background-clip: text;
}"
`)
Expand Down

0 comments on commit 04dcf27

Please sign in to comment.