ts_noise: add regression tests to check that key types are zeroized#221
Merged
Conversation
dylan-tailscale
approved these changes
Jun 4, 2026
dylan-tailscale
left a comment
dylan-tailscale
left a comment
Collaborator
There was a problem hiding this comment.
lgtm, this isn't ideal but after reading through the conversation in #rust re: Drop impls and moving fields, I don't have a fundamentally better solution.
danderson
force-pushed
the
push-tqznrnywrrvw
branch
2 times, most recently
from
875d4ce to
1ea6755
Compare
danderson
force-pushed
the
push-rkvynlqoptsy
branch
2 times, most recently
from
4fafcd3 to
30fef8d
Compare
Updates #21 Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: I8f41ce9ba6718333c76d7d1f80fe0b8b6a6a6964
danderson
force-pushed
the
push-rkvynlqoptsy
branch
from
30fef8d to
e28b47f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #186, but it's for #21, to stop us accidentally weakening ts_noise's forward secrecy properties when we update the rustcrypto crates.