feat: use Into trait for Valid::trace (#23)

Co-authored-by: Tushar Mathur <[email protected]>

Author: meskill

.gitignore

@@ -1,3 +1,4 @@
 /target
 /.idea
-/build
+/.vscode
+/build

src/valid.rs

@@ -50,15 +50,12 @@ pub trait Validator<A, E, T>: Sized {
         Fusion(self.zip(other))
     }
 
-    fn trace(self, trace: T) -> Valid<A, E, T>
-    where
-        T: Clone,
-    {
+    fn trace(self, trace: impl Into<T> + Clone) -> Valid<A, E, T> {
         let valid = self.to_result();
         if let Err(error) = valid {
             return Valid(Err(error
                 .into_iter()
-                .map(|cause| cause.trace(trace.clone()))
+                .map(|cause| cause.trace(trace.clone().into()))
                 .collect()));
         }
 
@@ -121,10 +118,6 @@ impl<A, E, T> Valid<A, E, T> {
         Valid(Err(vec![cause]))
     }
 
-    pub fn from(error: Vec<Cause<E, T>>) -> Self {
-        Valid(Err(error))
-    }
-
     pub fn succeed(a: A) -> Valid<A, E, T> {
         Valid(Ok(a))
     }
@@ -306,9 +299,9 @@ mod tests {
     #[test]
     fn test_trace() {
         let result = Valid::<(), i32, String>::fail(1)
-            .trace("A".into())
-            .trace("B".into())
-            .trace("C".into());
+            .trace("A")
+            .trace("B")
+            .trace("C");
 
         let expected = Valid::from(vec![Cause {
             error: 1,
@@ -403,4 +396,20 @@ mod tests {
         assert_eq!(result, Valid::fail(1));
         assert_eq!(a, 0);
     }
+
+    #[test]
+    fn test_trace_owned_referenced() {
+        let trace_value = "inner".to_string();
+
+        let valid: Valid<((), ()), &str, String> = Valid::fail("fail")
+            .trace(&trace_value)
+            .zip(Valid::fail("fail 2").trace(trace_value))
+            .trace("outer");
+
+        let causes = valid.to_result().unwrap_err();
+
+        assert_eq!(causes.len(), 2);
+        assert_eq!(causes[0].to_string(), "[outer, inner] fail");
+        assert_eq!(causes[1].to_string(), "[outer, inner] fail 2");
+    }
 }