Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axi_slave_sub_driver don't reset response_queue #49

Closed
kkurenkov opened this issue Apr 11, 2023 · 4 comments · Fixed by #50
Closed

axi_slave_sub_driver don't reset response_queue #49

kkurenkov opened this issue Apr 11, 2023 · 4 comments · Fixed by #50
Labels
bug Something isn't working

Comments

@kkurenkov
Copy link
Contributor

Hi Taichi!
I have a problemlem connected with AXI Slave

Screenshot from 2023-04-11 11-27-07

After reset i see response on R channel...

I find a problem
https://github.com/taichi-ishitani/tvip-axi/blob/master/src/tvip_axi_slave_driver.svh#L147

must delete in task
https://github.com/taichi-ishitani/tvip-axi/blob/master/src/tvip_axi_slave_driver.svh#L196


    protected task do_reset();
    start_delay_consumer.do_reset();

    ...............................................

    active_responses.delete();
    active_ids.delete();
    
    response_queue.delete();    <-------- !


    reset_if();
    @(posedge vif.areset_n);
  endtask
@taichi-ishitani taichi-ishitani added the bug Something isn't working label Apr 11, 2023
@taichi-ishitani
Copy link
Owner

Hi @kkurenkov ,

Thank you for reporting this issue!

Your understanding is correct so can you open a PR to fix this?
I'd like to insert code to delete response_queue after this line.

tvip-axi/src/tvip_axi_slave_driver.svh

Line 211 in fe2c876

end

@kkurenkov
Copy link
Contributor Author

@taichi-ishitani

#50

@taichi-ishitani taichi-ishitani linked a pull request Apr 11, 2023 that will close this issue
delete response_queue when reset #50
Merged
taichi-ishitani pushed a commit that referenced this issue Apr 11, 2023
@kkurenkov
delete response_queue when reset (#50, #49)
843c4a2
@taichi-ishitani
Copy link
Owner

Thank you for opening the PR!
I've merged it.

@taichi-ishitani
Copy link
Owner

@kkurenkov ,

By the way, I'm developing utility tools below for RTL develpment. Can you try to use those tools if you have enough time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

delete response_queue when reset kkurenkov/tvip-axi
2 participants
@taichi-ishitani @kkurenkov