Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with On the Fly Reset #46

Closed
kkurenkov opened this issue Dec 26, 2022 · 5 comments · Fixed by #47
Closed

Problem with On the Fly Reset #46

kkurenkov opened this issue Dec 26, 2022 · 5 comments · Fixed by #47
Assignees
@taichi-ishitani
Labels
bug Something isn't working

Comments

@kkurenkov
Copy link
Contributor

Hi @taichi-ishitani ! I have a problem when i have reset on AXI.
In my test I have AXI4 slave and DUT.
When i asserted reset the BValid, Bid not reset to zero.
The figure below
1_problem

So i find the problem. I think it happened because of race conditions
https://github.com/taichi-ishitani/tvip-axi/blob/master/src/tvip_axi_slave_driver.svh#L524

this happened after

  protected task drive_response(bit valid, tvip_axi_slave_driver_response_item item);
    vif.slave_cb.bvalid <= valid;
    if (valid) begin
      vif.slave_cb.bid    <= item.get_id();
      vif.slave_cb.bresp  <= item.get_response_status();
    end
  endtask

This

protected task reset_if();
  vif.awready = configuration.default_awready;
  vif.wready  = configuration.default_wready;
  vif.bvalid  = '0;
  vif.bid     = '0;
  vif.bresp   = tvip_axi_response'(0);
endtask

So my decision

  protected task drive_response(bit valid, tvip_axi_slave_driver_response_item item);
    vif.bvalid <= valid;
    if (valid) begin
      vif.bid    <= item.get_id();
      vif.bresp  <= item.get_response_status();
    end
  endtask

I'm not sure, that I understand your logic correctly, but in my case, it's work fine...

2_solve

Best regards.
@kkurenkov
Copy link
Contributor Author

Also, the same situation in R channel
image

taichi-ishitani added a commit that referenced this issue Jan 5, 2023
@taichi-ishitani
add areset_n to clocking event of master_cb/slave_cb
0983d05 
(refs: #46)
@taichi-ishitani taichi-ishitani self-assigned this Jan 5, 2023
@taichi-ishitani taichi-ishitani added the bug Something isn't working label Jan 5, 2023
@taichi-ishitani
Copy link
Owner

taichi-ishitani commented Jan 5, 2023 •
edited
Loading

Hi @kkurenkov ,

Thank you for opening this issue and sorry for delay response.
I pushed the fix for this issue to fix_46 branch.
https://github.com/taichi-ishitani/tvip-axi/tree/fix_46

Can you try to use it?

@kkurenkov
Copy link
Contributor Author

Hi @taichi-ishitani !
Ok, I'll check your decision tomorrow.
Also, I'll try to check master agent.

@kkurenkov
Copy link
Contributor Author

Hi @taichi-ishitani ! I checked your fix and all works fine. Thank you for your work!

@taichi-ishitani taichi-ishitani mentioned this issue Jan 9, 2023
Merged
taichi-ishitani added a commit that referenced this issue Jan 9, 2023
@taichi-ishitani
add areset_n to clocking event of master_cb/slave_cb (#47)
fe2c876 
fix #46
@taichi-ishitani
Copy link
Owner

I've merged the fix to master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taichi-ishitani taichi-ishitani

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add areset_n to clocking event of master_cb/slave_cb taichi-ishitani/tvip-axi
2 participants
@taichi-ishitani @kkurenkov