Merge branch 'main' into switch-to-added-network

Author: hyphenized

.env.defaults

@@ -32,4 +32,4 @@ SUPPORT_SWAP_QUOTE_REFRESH=false
 SUPPORT_ACHIEVEMENTS_BANNER=false
 SUPPORT_NFT_SEND=false
 USE_MAINNET_FORK=false
-ENABLE_UPDATED_DAPP_CONNECTIONS=false
+ENABLE_UPDATED_DAPP_CONNECTIONS=true

.eslintrc.js

@@ -92,7 +92,13 @@ module.exports = {
         ],
       },
     ],
-    "@typescript-eslint/no-unused-vars": "error",
+    "@typescript-eslint/no-unused-vars": [
+      "error",
+      {
+        argsIgnorePattern: "^_",
+        varsIgnorePattern: "^_",
+      },
+    ],
     "no-unused-vars": "off",
   },
   ignorePatterns: [

.github/CODEOWNERS

@@ -1,8 +1,8 @@
-# Any changes to keyring code deserve extra scrutiny to prevent key
+# Any changes to internal-signer service code deserve extra scrutiny to prevent key
 # exfiltration and general "roll your own crypto" mistakes. Newer
-# contributions to keyring code should be assumed insecure, requiring
+# contributions to internal-signer code should be assumed insecure, requiring
 # agreement across the team to merge.
-/background/services/keyring/* @tahowallet/extension-security-auditors
+/background/services/internal-signer/* @tahowallet/extension-security-auditors
 # Any changes to dependencies deserve extra scrutiny to help prevent supply
 # chain attacks
 yarn.lock @tahowallet/extension-dependency-auditors

.github/ISSUE_TEMPLATE/BUG.yml

@@ -51,6 +51,9 @@ body:
       label: Version
       description: What version of the extension are you running?
       options:
+        - v0.41.0
+        - v0.40.2
+        - v0.40.1
         - v0.40.0
         - v0.39.0
         - v0.38.1

.github/workflows/sync-pledge.yml

@@ -4,7 +4,6 @@ on:
   schedule:
     - cron: "0 0 */3 * *"
   workflow_dispatch:
-  pull_request: {}
 
 jobs:
   cron:

README.md

@@ -243,7 +243,7 @@ services (in the API package) and the interface and browser notifications:
 │                 │                                                    - On-chain prices        ┃     │      └─────────────────┘
 │                 │                                                                             ┃     │
 │                 │                                                                             ┃     │      ┌────────────────┐
-│                 │                                                   Keyring                   ┃     │      │                │
+│                 │                                                   Internal Signer           ┃     │      │                │
 │                 ├──────list accounts, sign tx, sign message───────▶ - Native  ────────────────╋─────┼──────▶   Extension    │
 │                 │                                                   - Remote                  ┃     │      │  Storage API   │
 │      ┌──────────┴──────────┐                                                                  ┃     │      │                │

background/lib/posthog.ts

@@ -12,6 +12,8 @@ export enum AnalyticsEvent {
   NEW_ACCOUNT_TO_TRACK = "Address added to tracking on network",
   CUSTOM_CHAIN_ADDED = "Custom chain added",
   DAPP_CONNECTED = "Dapp Connected",
+  VAULT_MIGRATION = "Migrate to newer vault version",
+  VAULT_MIGRATION_FAILED = "Vault version migration failed",
 }
 
 export enum OneTimeAnalyticsEvent {

background/lib/token-lists.ts

@@ -22,7 +22,7 @@ import { DeepWriteable } from "../types"
 const cleanTokenListResponse = (json: any, url: string) => {
   if (url.includes("api-polygon-tokens.polygon.technology")) {
     if (typeof json === "object" && json !== null && "tags" in json) {
-      const { tags, ...cleanedJson } = json
+      const { tags: _, ...cleanedJson } = json
       return cleanedJson
     }
   }

background/lib/utils/index.ts

@@ -108,14 +108,14 @@ export function gweiToWei(value: number | bigint): bigint {
   return BigInt(utils.parseUnits(value.toString(), "gwei").toString())
 }
 
-export function convertToEth(value: string | number | bigint): string {
+export function convertToEth(value: bigint): string {
   if (value && value >= 1) {
     return utils.formatUnits(BigInt(value))
   }
   return ""
 }
 
-export function weiToGwei(value: string | number | bigint): string {
+export function weiToGwei(value: bigint): string {
   if (value && value >= 1) {
     return truncateDecimalAmount(utils.formatUnits(BigInt(value), "gwei"), 2)
   }

background/lib/validate/prices.ts

@@ -27,7 +27,7 @@ export const coingeckoPriceSchema: JSONSchemaType<CoingeckoPriceData> = {
     additionalProperties: { type: "number", nullable: true },
     nullable: true,
   },
-}
+} as const
 
 export type CoingeckoPriceData = {
   [coinId: string]: