fix(errmsg): should not return debug info of key cell when parsing map value as message (#307)

* fix(errmsg): should not return debug info of key cell when parsing map value as message

* fix: error desc kv pairs, the last one wins

Author: wenchy

internal/confgen/table_parser.go

@@ -248,7 +248,7 @@ func (sp *tableParser) parseVerticalMapField(field *Field, msg protoreflect.Mess
 	}
 	valuePresent, err := sp.parseMessage(newMapValue.Message(), rc, newPrefix, newCardPrefix)
 	if err != nil {
-		return false, xerrors.WrapKV(err, rc.CellDebugKV(keyColName)...)
+		return false, err
 	}
 	if !keyPresent && !valuePresent {
 		// key and value are both not present.
@@ -305,7 +305,7 @@ func (sp *tableParser) parseHorizontalMapField(field *Field, msg protoreflect.Me
 			tempCheckMapValue := reflectMap.NewValue()
 			valuePresent, err := sp.parseMessage(tempCheckMapValue.Message(), rc, elemPrefix, newCardPrefix)
 			if err != nil {
-				return false, xerrors.WrapKV(err, rc.CellDebugKV(keyColName)...)
+				return false, err
 			}
 			if valuePresent {
 				return false, xerrors.WrapKV(xerrors.E2017(xproto.GetFieldTypeName(field.fd)), rc.CellDebugKV(keyColName)...)

xerrors/desc.go

@@ -95,12 +95,14 @@ func NewDesc(err error) *Desc {
 		fields: map[string]any{},
 	}
 
+	// NOTE: In the splits slice, the latter key-value pairs will overwrite
+	// earlier ones if they have the same key, so the last one wins.
 	splits := strings.Split(err.Error(), "|")
 	for _, s := range splits {
 		kv := strings.SplitN(s, ":", 2)
 		if len(kv) == 2 {
 			key, val := strings.Trim(kv[0], " :"), strings.Trim(kv[1], " :")
-			if key != "" && val != "" {
+			if key != "" {
 				desc.setField(key, val)
 			}
 		}