From 73f9693b600dcd26f3913a8905e368f62819bef3 Mon Sep 17 00:00:00 2001 From: ixrzr Date: Sun, 19 Jan 2025 19:11:56 +0100 Subject: [PATCH] chore: enhance contribution guidelines, fix PR template & add 2 new icons --- .github/CONTRIBUTING.md | 6 ++++++ .github/pull_request_template.md | 4 ++-- icons/actix.svg | 4 ++++ icons/stackoverflow.svg | 14 ++++++++++++++ src/routes/index.ts | 4 +++- 5 files changed, 29 insertions(+), 3 deletions(-) create mode 100644 icons/actix.svg create mode 100644 icons/stackoverflow.svg diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 5cdf851..3ae1cab 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -30,6 +30,12 @@ If you'd like to contribute a new icon, please follow these steps: - Icons should be placed in the /icons directory. Ensure the icon file is named consistently with the naming convention (e.g., iconname.svg). +### 3. Pull Request Review Process + +Once you submit a pull request, the maintainers will review it and may ask for clarifications or changes. Please be responsive to any feedback or requests for changes. + +If the pull request opener does not respond to the maintainer's questions or requested changes within **one week**, the pull request may be closed as **abandoned**. + ## Code of Conduct By contributing to this project, you agree to follow our [Code of Conduct](CODE_OF_CONDUCT.md), which sets expectations for respectful and inclusive communication. diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index d335159..6dc8ef4 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -2,11 +2,11 @@ ### Icon Name -- () Specify the name of the icon here. +- Specify the name of the icon here. ### Checklist -- [ ] The icon is created using one of the provided [icon templates](icon-templates) +- [ ] The icon is created using one of the provided [icon templates](https://github.com/ixrzr/skills-icons/tree/main/.github/icon-templates) - [ ] The icon is added to the correct directory (`/icons`). - [ ] A preview image is attached. - [ ] The icon name follows the naming convention (e.g., `iconname.svg`). diff --git a/icons/actix.svg b/icons/actix.svg new file mode 100644 index 0000000..e4e43bb --- /dev/null +++ b/icons/actix.svg @@ -0,0 +1,4 @@ + + + + \ No newline at end of file diff --git a/icons/stackoverflow.svg b/icons/stackoverflow.svg new file mode 100644 index 0000000..2b81296 --- /dev/null +++ b/icons/stackoverflow.svg @@ -0,0 +1,14 @@ + + + + + + \ No newline at end of file diff --git a/src/routes/index.ts b/src/routes/index.ts index 06ab294..2129cd0 100644 --- a/src/routes/index.ts +++ b/src/routes/index.ts @@ -33,6 +33,7 @@ const shortNames: Record = { "kali": "kalilinux", "lottie": "lottiefiles", "manifold": "manifoldjs", + "mui": "materialui", "md": "markdown", "mongo": "mongodb", "node": "nodejs", @@ -45,12 +46,13 @@ const shortNames: Record = { "sclearn": "scikitlearn", "solid": "solidjs", "spring": "springboot", + "so": "stackoverflow", "tailwind": "tailwindcss", "ts": "typescript", "vscode": "visualstudiocode", "vue": "vuejs", "wp": "wordpress" -}; +} const shortNamesReverse: Record = {}; Object.entries(shortNames).forEach(([short, full]) => {