Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate hetzner-ci.yaml and hetzner.yaml #1528

Open
guettli opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1527
Open

Deduplicate hetzner-ci.yaml and hetzner.yaml #1528

guettli opened this issue Jan 8, 2025 · 0 comments · May be fixed by #1527

Comments

@guettli
Copy link
Collaborator

guettli commented Jan 8, 2025

/kind feature

The files test/e2e/config/hetzner-ci.yaml and test/e2e/config/hetzner.yaml are very similar.

I think we should de-duplicate these files:

  1. Create the common base as hetzner.yaml
  2. Do modifications which are needed for hetzner-ci.yaml "on the fly" during ci.
  3. Delete hetzner-ci.yaml from the git repo.

During the last months I was confused by that several times.

CI overwrites it like this:

        E2E_CONF_FILE_SOURCE: "${{ github.workspace }}/test/e2e/config/hetzner-ci.yaml"

file: .github/actions/e2e/action.yaml

@guettli guettli changed the title Deduplicate test/e2e/config/hetzner-ci.yaml and test/e2e/config/hetzner.yaml Deduplicate hetzner-ci.yaml and hetzner.yaml Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant