Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Commit 85a10ef

Browse files
SynapticloopSynapticloop
authored andcommitted
updated logging and minor code change
1 parent 70cb509 commit 85a10ef

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/main/java/synapticloop/b2/request/BaseB2Request.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -358,6 +358,8 @@ private void setHeaders(Logger LOGGER, HttpRequestBase httpRequestBase) {
358358
if(!httpRequestBase.containsHeader(headerKey)) {
359359
LOGGER.trace("Setting header (encoded) '{}'.", headerKey);
360360
httpRequestBase.setHeader(headerKey, Helper.urlEncode(headers.get(headerKey)));
361+
} else {
362+
LOGGER.warn("Attempting to set header (encoded) '{}', which already exists, ignoring...", headerKey);
361363
}
362364
}
363365

@@ -366,6 +368,8 @@ private void setHeaders(Logger LOGGER, HttpRequestBase httpRequestBase) {
366368
if(!httpRequestBase.containsHeader(headerKey)) {
367369
LOGGER.trace("Setting header (un-encoded) '{}'.", headerKey);
368370
httpRequestBase.setHeader(headerKey, unencodedHeaders.get(headerKey));
371+
} else {
372+
LOGGER.warn("Attempting to set header (un-encoded) '{}', which already exists, ignoring...", headerKey);
369373
}
370374
}
371375
}

src/main/java/synapticloop/b2/util/Helper.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
import synapticloop.b2.exception.B2ApiException;
1515

1616
public class Helper {
17+
private static final String SHA_1 = "SHA-1";
1718
private static final String UTF_8 = "UTF-8";
1819

1920
/**
@@ -32,7 +33,7 @@ public static String calculateSha1(File file) throws B2ApiException {
3233
MessageDigest messageDigest = null;
3334
InputStream inputStream = null;
3435
try {
35-
messageDigest = MessageDigest.getInstance("SHA-1");
36+
messageDigest = MessageDigest.getInstance(SHA_1);
3637
inputStream = new BufferedInputStream(new FileInputStream(file));
3738
byte[] buffer = new byte[8192];
3839
int len = inputStream.read(buffer);

0 commit comments

Comments
 (0)