Skip to content

Commit fd93a4e

Browse files
committed
feature #710 bump: style-loader version 1.X (Grafikart)
This PR was merged into the master branch. Discussion ---------- bump: style-loader version 1.X The webpack encore version style loader is too old and inject CSS using `<link>` instead of `<style>`. This solution loads style asynchronously cause lots of problem with JavaScript. With this upgrade style-loader doesn't accept sourcemap anymore. SourceMap support is calculated from previous loaders (https://github.com/webpack-contrib/style-loader#source-maps) Commits ------- c7f7e92 bump: style-loader
2 parents bdf8ba4 + c7f7e92 commit fd93a4e

File tree

3 files changed

+30
-10
lines changed

3 files changed

+30
-10
lines changed

lib/loaders/css-extract.js

-3
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ module.exports = {
2626
// style-loader instead.
2727
return [{
2828
loader: 'style-loader',
29-
options: {
30-
sourceMap: webpackConfig.useSourceMaps,
31-
}
3229
}, ...loaders];
3330
}
3431

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
"pretty-error": "^2.1.1",
4444
"resolve-url-loader": "^3.0.1",
4545
"semver": "^5.5.0",
46-
"style-loader": "^0.21.0",
46+
"style-loader": "^1.1.3",
4747
"terser-webpack-plugin": "^1.1.0",
4848
"tmp": "^0.0.33",
4949
"webpack": "^4.20.0",

yarn.lock

+29-6
Original file line numberDiff line numberDiff line change
@@ -1036,6 +1036,16 @@ ajv@^6.1.0, ajv@^6.10.2, ajv@^6.5.5, ajv@^6.9.1:
10361036
json-schema-traverse "^0.4.1"
10371037
uri-js "^4.2.2"
10381038

1039+
ajv@^6.12.0:
1040+
version "6.12.0"
1041+
resolved "https://registry.yarnpkg.com/ajv/-/ajv-6.12.0.tgz#06d60b96d87b8454a5adaba86e7854da629db4b7"
1042+
integrity sha512-D6gFiFA0RRLyUbvijN74DWAjXSFxWKaWP7mldxkVhyhAV3+SWA9HEJPHQ2c9soIeTFJqcSdFDGFgdqs1iUU2Hw==
1043+
dependencies:
1044+
fast-deep-equal "^3.1.1"
1045+
fast-json-stable-stringify "^2.0.0"
1046+
json-schema-traverse "^0.4.1"
1047+
uri-js "^4.2.2"
1048+
10391049
alphanum-sort@^1.0.0:
10401050
version "1.0.2"
10411051
resolved "https://registry.yarnpkg.com/alphanum-sort/-/alphanum-sort-1.0.2.tgz#97a1119649b211ad33691d9f9f486a8ec9fbe0a3"
@@ -3287,6 +3297,11 @@ fast-deep-equal@^2.0.1:
32873297
resolved "https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-2.0.1.tgz#7b05218ddf9667bf7f370bf7fdb2cb15fdd0aa49"
32883298
integrity sha1-ewUhjd+WZ79/Nwv3/bLLFf3Qqkk=
32893299

3300+
fast-deep-equal@^3.1.1:
3301+
version "3.1.1"
3302+
resolved "https://registry.yarnpkg.com/fast-deep-equal/-/fast-deep-equal-3.1.1.tgz#545145077c501491e33b15ec408c294376e94ae4"
3303+
integrity sha512-8UEa58QDLauDNfpbrX55Q9jrGHThw2ZMdOky5Gl1CDtVeJDPVrG4Jxx1N8jw2gkWaff5UUuX1KJd+9zGe2B+ZA==
3304+
32903305
fast-json-stable-stringify@^2.0.0:
32913306
version "2.0.0"
32923307
resolved "https://registry.yarnpkg.com/fast-json-stable-stringify/-/fast-json-stable-stringify-2.0.0.tgz#d5142c0caee6b1189f87d3a76111064f86c8bbf2"
@@ -7205,6 +7220,14 @@ schema-utils@^2.4.1:
72057220
ajv "^6.10.2"
72067221
ajv-keywords "^3.4.1"
72077222

7223+
schema-utils@^2.6.4:
7224+
version "2.6.5"
7225+
resolved "https://registry.yarnpkg.com/schema-utils/-/schema-utils-2.6.5.tgz#c758f0a7e624263073d396e29cd40aa101152d8a"
7226+
integrity sha512-5KXuwKziQrTVHh8j/Uxz+QUbxkaLW9X/86NBlx/gnKgtsZA2GIVMUn17qWhRFwF8jdYb3Dig5hRO/W5mZqy6SQ==
7227+
dependencies:
7228+
ajv "^6.12.0"
7229+
ajv-keywords "^3.4.1"
7230+
72087231
scss-tokenizer@^0.2.3:
72097232
version "0.2.3"
72107233
resolved "https://registry.yarnpkg.com/scss-tokenizer/-/scss-tokenizer-0.2.3.tgz#8eb06db9a9723333824d3f5530641149847ce5d1"
@@ -7746,13 +7769,13 @@ [email protected], strip-json-comments@^2.0.1, strip-json-comments@~2.0.
77467769
resolved "https://registry.yarnpkg.com/strip-json-comments/-/strip-json-comments-2.0.1.tgz#3c531942e908c2697c0ec344858c286c7ca0a60a"
77477770
integrity sha1-PFMZQukIwml8DsNEhYwobHygpgo=
77487771

7749-
style-loader@^0.21.0:
7750-
version "0.21.0"
7751-
resolved "https://registry.yarnpkg.com/style-loader/-/style-loader-0.21.0.tgz#68c52e5eb2afc9ca92b6274be277ee59aea3a852"
7752-
integrity sha512-T+UNsAcl3Yg+BsPKs1vd22Fr8sVT+CJMtzqc6LEw9bbJZb43lm9GoeIfUcDEefBSWC0BhYbcdupV1GtI4DGzxg==
7772+
style-loader@^1.1.3:
7773+
version "1.1.3"
7774+
resolved "https://registry.yarnpkg.com/style-loader/-/style-loader-1.1.3.tgz#9e826e69c683c4d9bf9db924f85e9abb30d5e200"
7775+
integrity sha512-rlkH7X/22yuwFYK357fMN/BxYOorfnfq0eD7+vqlemSK4wEcejFF1dg4zxP0euBW8NrYx2WZzZ8PPFevr7D+Kw==
77537776
dependencies:
7754-
loader-utils "^1.1.0"
7755-
schema-utils "^0.4.5"
7777+
loader-utils "^1.2.3"
7778+
schema-utils "^2.6.4"
77567779

77577780
stylehacks@^4.0.0:
77587781
version "4.0.3"

0 commit comments

Comments
 (0)