Skip to content

Commit cc268db

Browse files
committed
minor #1304 Replace fast-levenshtein by fastest-levenshtein (Kocal)
This PR was merged into the main branch. Discussion ---------- Replace `fast-levenshtein` by `fastest-levenshtein` Package [`fast-levenshtein`](https://www.npmjs.com/package/fast-levenshtein) is a wrapper around [`fastest-levenshtein`](https://www.npmjs.com/package/fastest-levenshtein), but we do not need locale-sensitive string comparaison. ``` Package size report =================== Package info for "`@symfony`/[email protected]": 61 MB Released: 2024-01-25 17:18:00.95 +0000 UTC (30w1d ago) Downloads last week: 48,107 (32.02%) Estimated traffic last week: 2.9 TB Subdependencies: 634 Removed dependencies: - [email protected]: 30 kB (0.04%) Downloads last week: 1,563,771 (N/A% from 3.0.0) Downloads last week from "`@symfony`/[email protected]": 48,107 (N/A%) Traffic last week: N/A Traffic from "`@symfony`/[email protected]": 2.9 TB (N/A%) Subdependencies: 1 (0.15%) Added dependencies: + [email protected]: 22 kB (0.03%) Downloads last week: 9,630,903 (N/A% from 1.0.16) Estimated traffic last week: N/A Subdependencies: 0 (0%) Estimated new statistics: Package size: 61 MB → 51 MB (83.09%) Subdependencies: 634 → 490 (-144) Traffic with last week's downloads: For current version: 2.9 TB → 2.4 TB (497 GB saved) For all versions: 9.2 TB → 7.6 TB (1.6 TB saved) ``` Commits ------- c4ac73a Replace `fast-levenshtein` by `fastest-levenshtein`
2 parents 24eb007 + c4ac73a commit cc268db

File tree

4 files changed

+6
-11
lines changed

4 files changed

+6
-11
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ module.exports = {
5252

5353
* #1297 Upgrade GitHub Actions in CI (@Kocal)
5454

55+
* #1304 Replace `fast-levenshtein` by `fastest-levenshtein` (@Kocal)
56+
5557
## [v4.6.1](https://github.com/symfony/webpack-encore/releases/tag/v4.6.1)
5658

5759
* #1256 Re-adding node 18 support (@weaverryan)

lib/EncoreProxy.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
'use strict';
1111

1212
const chalk = require('chalk');
13-
const levenshtein = require('fast-levenshtein');
13+
const levenshtein = require('fastest-levenshtein');
1414
const prettyError = require('./utils/pretty-error');
1515

1616
module.exports = {
@@ -69,7 +69,7 @@ module.exports = {
6969
continue;
7070
}
7171

72-
const distance = levenshtein.get(apiProperty, prop);
72+
const distance = levenshtein.distance(apiProperty, prop);
7373
if (distance <= minDistance) {
7474
similarProperty = apiProperty;
7575
minDistance = distance;

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"clean-webpack-plugin": "^4.0.0",
3535
"css-loader": "^6.7.0",
3636
"css-minimizer-webpack-plugin": "^5.0.0",
37-
"fast-levenshtein": "^3.0.0",
37+
"fastest-levenshtein": "^1.0.16",
3838
"mini-css-extract-plugin": "^2.6.0",
3939
"pkg-up": "^3.1.0",
4040
"pretty-error": "^4.0.0",

yarn.lock

+1-8
Original file line numberDiff line numberDiff line change
@@ -3711,14 +3711,7 @@ fast-levenshtein@^2.0.6, fast-levenshtein@~2.0.6:
37113711
resolved "https://registry.yarnpkg.com/fast-levenshtein/-/fast-levenshtein-2.0.6.tgz#3d8a5c66883a16a30ca8643e851f19baa7797917"
37123712
integrity sha512-DCXu6Ifhqcks7TZKY3Hxp3y6qphY5SJZmrWMDrKcERSOXWQdMhU9Ig/PYrzyw/ul9jOIyh0N4M0tbC5hodg8dw==
37133713

3714-
fast-levenshtein@^3.0.0:
3715-
version "3.0.0"
3716-
resolved "https://registry.yarnpkg.com/fast-levenshtein/-/fast-levenshtein-3.0.0.tgz#37b899ae47e1090e40e3fd2318e4d5f0142ca912"
3717-
integrity sha512-hKKNajm46uNmTlhHSyZkmToAc56uZJwYq7yrciZjqOxnlfQwERDQJmHPUp7m1m9wx8vgOe8IaCKZ5Kv2k1DdCQ==
3718-
dependencies:
3719-
fastest-levenshtein "^1.0.7"
3720-
3721-
fastest-levenshtein@^1.0.12, fastest-levenshtein@^1.0.7:
3714+
fastest-levenshtein@^1.0.12, fastest-levenshtein@^1.0.16:
37223715
version "1.0.16"
37233716
resolved "https://registry.yarnpkg.com/fastest-levenshtein/-/fastest-levenshtein-1.0.16.tgz#210e61b6ff181de91ea9b3d1b84fdedd47e034e5"
37243717
integrity sha512-eRnCtTTtGZFpQCwhJiUOuxPQWRXVKYDn0b2PeHfXL6/Zi53SLAzAHfVhVWK2AryC/WH05kGfxhFIPvTF0SXQzg==

0 commit comments

Comments
 (0)