feature #1118 Use cli param server-type to define devServer https mode (thegillou)

This PR was merged into the main branch.

Discussion
----------

Use cli param server-type to define devServer https mode

Check also the serverType cli param to define if the devServer is in https mode

Commits
-------

8926a47 Check server-type cli param to define if the dev-server is in https mode

Author: weaverryan

lib/config/parse-runtime.js

@@ -41,9 +41,12 @@ module.exports = function(argv, cwd) {
             runtimeConfig.verbose = true;
 
             runtimeConfig.useDevServer = true;
-            runtimeConfig.devServerHttps = argv.https;
             runtimeConfig.devServerKeepPublicPath = argv.keepPublicPath || false;
 
+            if (argv.https || argv.serverType === 'https') {
+                runtimeConfig.devServerHttps = true;
+            }
+
             if (typeof argv.public === 'string') {
                 runtimeConfig.devServerPublic = argv.public;
             }

test/config/parse-runtime.js

@@ -80,7 +80,7 @@ describe('parse-runtime', () => {
         expect(config.environment).to.equal('dev');
         expect(config.devServerHost).to.equal('foohost.l');
         expect(config.devServerPort).to.equal(9999);
-        expect(config.devServerHttps).to.be.undefined;
+        expect(config.devServerHttps).to.be.null;
     });
 
     it('dev-server command https', () => {
@@ -93,6 +93,16 @@ describe('parse-runtime', () => {
         expect(config.devServerHttps).to.equal(true);
     });
 
+    it('dev-server command server-type https', () => {
+        const testDir = createTestDirectory();
+        const config = parseArgv(createArgv(['dev-server', '--server-type', 'https', '--host', 'foohost.l', '--port', '9999']), testDir);
+
+        expect(config.useDevServer).to.be.true;
+        expect(config.devServerHost).to.equal('foohost.l');
+        expect(config.devServerPort).to.equal(9999);
+        expect(config.devServerHttps).to.equal(true);
+    });
+
     it('dev-server command public', () => {
         const testDir = createTestDirectory();
         const config = parseArgv(createArgv(['dev-server', '--public', 'https://my-domain:8080']), testDir);