Merge pull request #196 from andyexeter/master

Replace error throwing with logger warning when publicPath is not absolute

Author: weaverryan

lib/WebpackConfig.js

@@ -125,9 +125,9 @@ class WebpackConfig {
     setPublicPath(publicPath) {
         if (publicPath.includes('://') === false && publicPath.indexOf('/') !== 0) {
             // technically, not starting with "/" is legal, but not
-            // what you want in most cases. Let's not let the user make
-            // a mistake (and we can always change this later).
-            throw new Error('The value passed to setPublicPath() must start with "/" or be a full URL (http://...)');
+            // what you want in most cases. Let's warn the user that
+            // they might be making a mistake.
+            logger.warning('The value passed to setPublicPath() should *usually* start with "/" or be a full URL (http://...). If you\'re not sure, then you should probably change your public path and make this message disappear.');
         }
 
         // guarantee a single trailing slash

test/WebpackConfig.js

@@ -98,12 +98,11 @@ describe('WebpackConfig object', () => {
             expect(config.publicPath).to.equal('https://example.com/');
         });
 
-        it('foo/ throws an exception', () => {
+        it('You can omit the opening slash, but get a warning', () => {
             const config = createConfig();
+            config.setPublicPath('foo');
 
-            expect(() => {
-                config.setPublicPath('foo/');
-            }).to.throw('The value passed to setPublicPath() must start with "/"');
+            expect(logger.getMessages().warning).to.have.lengthOf(1);
         });
     });