Skip to content

Commit 3799313

Browse files
zairigimadweaverryan
authored andcommitted
add functional test for svelte
1 parent 21d7bea commit 3799313

File tree

3 files changed

+22
-2
lines changed

3 files changed

+22
-2
lines changed

fixtures/js/hello_world.svelte

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<script>
2+
let name = 'world';
3+
</script>
4+
5+
<h1>Hello {name}!</h1>

lib/config-generator.js

-2
Original file line numberDiff line numberDiff line change
@@ -404,8 +404,6 @@ class ConfigGenerator {
404404
}
405405

406406
if (this.webpackConfig.useSvelte) {
407-
loaderFeatures.ensurePackagesExistAndAreCorrectVersion('svelte');
408-
409407
rules.push(applyRuleConfigurationCallback('svelte', {
410408
resolve: {
411409
mainFields: ['svelte', 'browser', 'module', 'main'],

test/functional.js

+17
Original file line numberDiff line numberDiff line change
@@ -1309,6 +1309,23 @@ module.exports = {
13091309
});
13101310
});
13111311

1312+
it('When enabled, svelte is transformed', (done) => {
1313+
const config = createWebpackConfig('www/build', 'dev');
1314+
config.setPublicPath('/build');
1315+
config.addEntry('main', './js/hello_world.svelte');
1316+
config.enableSvelte();
1317+
1318+
testSetup.runWebpack(config, (webpackAssert) => {
1319+
// check that babel transformed the svelte files
1320+
webpackAssert.assertOutputFileContains(
1321+
'main.js',
1322+
'SvelteComponent'
1323+
);
1324+
1325+
done();
1326+
});
1327+
});
1328+
13121329
it('When enabled, preact JSX is transformed with preact-compat!', (done) => {
13131330
const config = createWebpackConfig('www/build', 'dev');
13141331
config.setPublicPath('/build');

0 commit comments

Comments
 (0)