Skip to content

[Config] Note that env vars are not always compatible with options #16383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2022
Merged

[Config] Note that env vars are not always compatible with options #16383

merged 1 commit into from
Sep 22, 2022

Conversation

melkamar
Copy link
Contributor

There are cases where environment variables cannot be used in
place of regular configuration options. This commit makes the limitation
explicit.

From symfony/symfony#39902

@melkamar @javiereguiluz
Note that env vars are not always compatible with options
6b73dda 
There are cases where environment variables cannot be used in
place of regular configuration options. This commit makes the limitation
explicit.

From symfony/symfony#39902
@javiereguiluz javiereguiluz changed the base branch from 6.0 to 5.4 September 22, 2022 08:17
@javiereguiluz javiereguiluz merged commit ecc8e44 into symfony:5.4 Sep 22, 2022
@javiereguiluz
Copy link
Member

Thanks @melkamar for this contribution. Please note that while merging, we reworded it to not ask readers to go to the GitHub issue for details. I hope it's clear enough. See 945bb67

@carsonbot carsonbot changed the title Note that env vars are not always compatible with options [Config] Note that env vars are not always compatible with options Sep 22, 2022
@javiereguiluz javiereguiluz added this to the 5.4 milestone Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Config Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@melkamar @javiereguiluz @carsonbot