[HttpKernel] Deprecate checking for cacheable HTTP methods in Request::isMethodSafe()

nicolas-grekas · nicolas-grekas · commit a6209fac5e59 · 2016-11-23T16:20:13.000+01:00
diff --git a/Firewall/ExceptionListener.php b/Firewall/ExceptionListener.php
@@ -220,7 +220,7 @@ private function startAuthentication(Request $request, AuthenticationException $
     protected function setTargetPath(Request $request)
     {
         // session isn't required when using HTTP basic authentication mechanism for example
-        if ($request->hasSession() && $request->isMethodSafe() && !$request->isXmlHttpRequest()) {
+        if ($request->hasSession() && $request->isMethodSafe(false) && !$request->isXmlHttpRequest()) {
             $this->saveTargetPath($request->getSession(), $this->providerKey, $request->getUri());
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -220,7 +220,7 @@ private function startAuthentication(Request $request, AuthenticationException $`
`220`	`220`	`protected function setTargetPath(Request $request)`
`221`	`221`	`{`
`222`	`222`	`// session isn't required when using HTTP basic authentication mechanism for example`
`223`		`- if ($request->hasSession() && $request->isMethodSafe() && !$request->isXmlHttpRequest()) {`
	`223`	`+ if ($request->hasSession() && $request->isMethodSafe(false) && !$request->isXmlHttpRequest()) {`
`224`	`224`	`$this->saveTargetPath($request->getSession(), $this->providerKey, $request->getUri());`
`225`	`225`	`}`
`226`	`226`	`}`