Ensure all handlers are explicitly closed on kernel shutdown

Author: andy-educake

DependencyInjection/MonologExtension.php

@@ -933,6 +933,8 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler
             $definition->addTag('kernel.reset', ['method' => 'reset']);
         }
 
+        $definition->addTag('monolog.handler');
+
         $container->setDefinition($handlerId, $definition);
 
         return $handlerId;

MonologBundle.php

@@ -52,4 +52,15 @@ public static function includeStacktraces(HandlerInterface $handler)
             $formatter->includeStacktraces();
         }
     }
+
+    public function shutdown()
+    {
+        parent::shutdown();
+
+        $handlerManager = $this->container->get('monolog.handler_manager');
+
+        $handlerManager->close();
+    }
+
+
 }

Resources/config/monolog.xml

@@ -40,5 +40,9 @@
         <service id="monolog.http_client" class="Symfony\Contracts\HttpClient\HttpClientInterface" public="false">
             <factory class="Symfony\Component\HttpClient\HttpClient" method="create" />
         </service>
+
+        <service id="monolog.handler_manager" class="Symfony\Bundle\MonologBundle\Services\HandlerManager" public="false">
+            <argument type="tagged" tag="monolog.handler" />
+        </service>
     </services>
 </container>

Services/HandlerManager.php

@@ -0,0 +1,28 @@
+<?php
+
+
+namespace Symfony\Bundle\MonologBundle\Services;
+
+
+use Monolog\Handler\HandlerInterface;
+
+class HandlerManager
+{
+
+    /**
+     * @var HandlerInterface[]
+     */
+    private $handlers;
+
+    public function __construct(array $handlers)
+    {
+        $this->handlers = $handlers;
+    }
+
+    public function close()
+    {
+        foreach ($this->handlers as $handler) {
+            $handler->close();
+        }
+    }
+}

Tests/DependencyInjection/MonologExtensionTest.php

@@ -89,6 +89,16 @@ public function testLoadWithNestedHandler()
         $this->assertDICConstructorArguments($handler, ['/tmp/symfony.log', \Monolog\Logger::ERROR, false, 0666, false]);
     }
 
+    public function testTagsAllHandlersCreated()
+    {
+        $container = $this->getContainer([['handlers' => [
+            'custom' => ['type' => 'stream', 'path' => '/tmp/symfony.log', 'bubble' => false, 'level' => 'ERROR', 'file_permission' => '0666'],
+            'nested' => ['type' => 'stream', 'path' => '/tmp/symfony.log', 'bubble' => false, 'level' => 'ERROR', 'file_permission' => '0666', 'nested' => true]
+        ]]]);
+        $taggedHandlers = $container->findTaggedServiceIds('monolog.handler');
+        $this->assertCount(2, $taggedHandlers);
+    }
+
     public function testLoadWithServiceHandler()
     {
         $container = $this->getContainer(