Skip to content

Commit ab54d92

Browse files
committed
minor #331 changing 2 files from phpunit.xml.dist to .env.test due to recipe changes (weaverryan)
This PR was squashed before being merged into the 1.0-dev branch (closes #331). Discussion ---------- changing 2 files from phpunit.xml.dist to .env.test due to recipe changes The recent changes away from phpunit.xml.dist broke some of our tests. Commits ------- 333a792 changing 2 files from phpunit.xml.dist to .env.test due to recipe changes
2 parents ac04799 + 333a792 commit ab54d92

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed

src/Test/MakerTestDetails.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -135,11 +135,6 @@ public function configureDatabase(bool $createSchema = true): self
135135
// currently, we need to replace this in *both* files so we can also
136136
// run bin/console commands
137137
$this
138-
->addReplacement(
139-
'phpunit.xml.dist',
140-
'mysql://db_user:[email protected]:3306/db_name',
141-
getenv('TEST_DATABASE_DSN')
142-
)
143138
->addReplacement(
144139
'.env',
145140
'mysql://db_user:[email protected]:3306/db_name',

src/Test/MakerTestEnvironment.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,9 +102,9 @@ private function changeRootNamespaceIfNeeded()
102102
'replace' => $rootNamespace.'\\',
103103
],
104104
[
105-
'filename' => 'phpunit.xml.dist',
106-
'find' => '<env name="KERNEL_CLASS" value="App\\Kernel" />',
107-
'replace' => '<env name="KERNEL_CLASS" value="'.$rootNamespace.'\\Kernel" />',
105+
'filename' => '.env.test',
106+
'find' => 'KERNEL_CLASS=\'App\Kernel\'',
107+
'replace' => 'KERNEL_CLASS=\''.$rootNamespace.'\Kernel\'',
108108
],
109109
];
110110

@@ -337,9 +337,9 @@ private function buildFlexSkeleton()
337337
// temporarily ignoring indirect deprecations - see #237
338338
$replacements = [
339339
[
340-
'filename' => 'phpunit.xml.dist',
341-
'find' => '</php>',
342-
'replace' => ' <env name="SYMFONY_DEPRECATIONS_HELPER" value="weak_vendors" />'."\n".' </php>',
340+
'filename' => '.env.test',
341+
'find' => 'SYMFONY_DEPRECATIONS_HELPER=999999',
342+
'replace' => 'SYMFONY_DEPRECATIONS_HELPER=weak_vendors',
343343
],
344344
];
345345
$this->processReplacements($replacements, $this->flexPath);

0 commit comments

Comments
 (0)