Skip to content

Commit 6a98e92

Browse files
committed
minor #72 chore: remove occurrences of empty() (alexandre-daubois, chr-hertel)
This PR was merged into the main branch. Discussion ---------- chore: remove occurrences of `empty()` | Q | A | ------------- | --- | Bug fix? | no | New feature? |no | Docs? | no | Issues | | License | MIT Cherry picking php-llm/llm-chain#374 Commits ------- c0d688f chore: use [] checks instead of count with zero on array fb3d1a8 chore: use isset instead of bool cast on $_ENV 14c448c chore: remove occurrences of `empty()` (#374)
2 parents 4807521 + c0d688f commit 6a98e92

File tree

102 files changed

+109
-112
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

102 files changed

+109
-112
lines changed

examples/anthropic/chat.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
require_once dirname(__DIR__).'/vendor/autoload.php';
2020
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
2121

22-
if (empty($_ENV['ANTHROPIC_API_KEY'])) {
22+
if (!isset($_ENV['ANTHROPIC_API_KEY'])) {
2323
echo 'Please set the ANTHROPIC_API_KEY environment variable.'.\PHP_EOL;
2424
exit(1);
2525
}

examples/anthropic/image-input-binary.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
require_once dirname(__DIR__).'/vendor/autoload.php';
2121
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
2222

23-
if (empty($_ENV['ANTHROPIC_API_KEY'])) {
23+
if (!isset($_ENV['ANTHROPIC_API_KEY'])) {
2424
echo 'Please set the ANTHROPIC_API_KEY environment variable.'.\PHP_EOL;
2525
exit(1);
2626
}

examples/anthropic/image-input-url.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
require_once dirname(__DIR__).'/vendor/autoload.php';
2121
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
2222

23-
if (empty($_ENV['ANTHROPIC_API_KEY'])) {
23+
if (!isset($_ENV['ANTHROPIC_API_KEY'])) {
2424
echo 'Please set the ANTHROPIC_API_KEY environment variable.'.\PHP_EOL;
2525
exit(1);
2626
}

examples/anthropic/pdf-input-binary.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
require_once dirname(__DIR__).'/vendor/autoload.php';
2121
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
2222

23-
if (empty($_ENV['ANTHROPIC_API_KEY'])) {
23+
if (!isset($_ENV['ANTHROPIC_API_KEY'])) {
2424
echo 'Please set the ANTHROPIC_API_KEY environment variable.'.\PHP_EOL;
2525
exit(1);
2626
}

examples/anthropic/pdf-input-url.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
require_once dirname(__DIR__).'/vendor/autoload.php';
2121
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
2222

23-
if (empty($_ENV['ANTHROPIC_API_KEY'])) {
23+
if (!isset($_ENV['ANTHROPIC_API_KEY'])) {
2424
echo 'Please set the ANTHROPIC_API_KEY environment variable.'.\PHP_EOL;
2525
exit(1);
2626
}

examples/anthropic/stream.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
require_once dirname(__DIR__).'/vendor/autoload.php';
2020
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
2121

22-
if (empty($_ENV['ANTHROPIC_API_KEY'])) {
22+
if (!isset($_ENV['ANTHROPIC_API_KEY'])) {
2323
echo 'Please set the ANTHROPIC_API_KEY environment variable.'.\PHP_EOL;
2424
exit(1);
2525
}

examples/anthropic/toolcall.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
require_once dirname(__DIR__).'/vendor/autoload.php';
2424
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
2525

26-
if (empty($_ENV['ANTHROPIC_API_KEY'])) {
26+
if (!isset($_ENV['ANTHROPIC_API_KEY'])) {
2727
echo 'Please set the ANTHROPIC_API_KEY environment variable.'.\PHP_EOL;
2828
exit(1);
2929
}

examples/azure/audio-transcript.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717
require_once dirname(__DIR__).'/vendor/autoload.php';
1818
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
1919

20-
if (empty($_ENV['AZURE_OPENAI_BASEURL']) || empty($_ENV['AZURE_OPENAI_WHISPER_DEPLOYMENT']) || empty($_ENV['AZURE_OPENAI_WHISPER_API_VERSION']) || empty($_ENV['AZURE_OPENAI_KEY'])
21-
) {
20+
if (!isset($_ENV['AZURE_OPENAI_BASEURL'], $_ENV['AZURE_OPENAI_WHISPER_DEPLOYMENT'], $_ENV['AZURE_OPENAI_WHISPER_API_VERSION'], $_ENV['AZURE_OPENAI_KEY'])) {
2221
echo 'Please set the AZURE_OPENAI_BASEURL, AZURE_OPENAI_WHISPER_DEPLOYMENT, AZURE_OPENAI_WHISPER_API_VERSION, and AZURE_OPENAI_KEY environment variables.'.\PHP_EOL;
2322
exit(1);
2423
}

examples/azure/chat-gpt.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
require_once dirname(__DIR__).'/vendor/autoload.php';
2020
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
2121

22-
if (empty($_ENV['AZURE_OPENAI_BASEURL']) || empty($_ENV['AZURE_OPENAI_GPT_DEPLOYMENT']) || empty($_ENV['AZURE_OPENAI_GPT_API_VERSION']) || empty($_ENV['AZURE_OPENAI_KEY'])
23-
) {
22+
if (!isset($_ENV['AZURE_OPENAI_BASEURL'], $_ENV['AZURE_OPENAI_GPT_DEPLOYMENT'], $_ENV['AZURE_OPENAI_GPT_API_VERSION'], $_ENV['AZURE_OPENAI_KEY'])) {
2423
echo 'Please set the AZURE_OPENAI_BASEURL, AZURE_OPENAI_GPT_DEPLOYMENT, AZURE_OPENAI_GPT_API_VERSION, and AZURE_OPENAI_KEY environment variables.'.\PHP_EOL;
2524
exit(1);
2625
}

examples/azure/chat-llama.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
require_once dirname(__DIR__).'/vendor/autoload.php';
2020
(new Dotenv())->loadEnv(dirname(__DIR__).'/.env');
2121

22-
if (empty($_ENV['AZURE_LLAMA_BASEURL']) || empty($_ENV['AZURE_LLAMA_KEY'])) {
22+
if (!isset($_ENV['AZURE_LLAMA_BASEURL'], $_ENV['AZURE_LLAMA_KEY'])) {
2323
echo 'Please set the AZURE_LLAMA_BASEURL and AZURE_LLAMA_KEY environment variable.'.\PHP_EOL;
2424
exit(1);
2525
}

0 commit comments

Comments
 (0)