Skip to content

Commit 0c89839

Browse files
authored
Merge pull request #41 from tri-adam/update-linter
Update Linter
2 parents 05e7267 + 4e344bd commit 0c89839

File tree

3 files changed

+6
-10
lines changed

3 files changed

+6
-10
lines changed

.golangci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ linters:
1212
- gosimple
1313
- govet
1414
- ineffassign
15-
- maligned
1615
- misspell
1716
- nakedret
1817
# we would like to add these

INSTALL.md

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,21 +59,18 @@ $ echo 'export GOPATH=${HOME}/go' >> ~/.bashrc && \
5959

6060
This is an optional (but highly recommended!) step. To ensure
6161
consistency and to catch certain kinds of issues early, we provide a
62-
configuration file for golangci-lint. Every pull request must pass the
62+
configuration file for `golangci-lint`. Every pull request must pass the
6363
checks specified there, and these will be run automatically before
6464
attempting to merge the code. If you are modifying Singularity and
6565
contributing your changes to the repository, it's faster to run these
6666
checks locally before uploading your pull request.
6767

68-
In order to install golangci-lint, you can run:
68+
In order to download and install the latest version of `golangci-lint`,
69+
you can run:
6970

71+
```sh
72+
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin
7073
```
71-
$ curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh |
72-
sh -s -- -b $(go env GOPATH)/bin v1.31.0
73-
```
74-
75-
This will download and install golangci-lint from its Github releases
76-
page (using version v1.31.0 at the moment).
7774

7875
## Clone the repo
7976

scripts/run-linter

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
set -e
44

5-
golangci_lint_version=1.31.0
5+
golangci_lint_version=1.40.1
66
golangci_lint_install_url=https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh
77

88
info() {

0 commit comments

Comments
 (0)