Skip to content

Use the exising breakpoints utlity in the new composible header #4527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oliverschuerch opened this issue Jan 27, 2025 · 1 comment
Closed
Assignees
Labels
📦 components Related to the @swisspost/design-system-components package Header Everything related to our composible header components

Comments

@oliverschuerch
Copy link
Contributor

In the new composible header component we use a custom breakpoint detection mechanism.
But there is a breakpoints utility which should be used, so we can reduce code, improve page performance and maintain the detection mechanism from a single source of truth.

Have a look into the utility: https://github.com/swisspost/design-system/blob/main/packages/components/src/utils/breakpoints.ts
And how it is used in the post-footer component: https://github.com/swisspost/design-system/blob/main/packages/components/src/components/post-footer/post-footer.tsx

@oliverschuerch oliverschuerch added the 📦 components Related to the @swisspost/design-system-components package label Jan 27, 2025
@oliverschuerch oliverschuerch added this to the Maintenance III milestone Jan 27, 2025
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Jan 29, 2025
@oliverschuerch oliverschuerch added the Header Everything related to our composible header components label Jan 30, 2025
@alionazherdetska alionazherdetska self-assigned this Feb 11, 2025
@alionazherdetska alionazherdetska moved this from 💻 Ready for development to 🤬 Dev in Code Review in Design System Production Board Feb 11, 2025
@gfellerph gfellerph moved this from 🤬 Dev in Code Review to 🧐 In Review in Design System Production Board Mar 13, 2025
@alionazherdetska
Copy link
Contributor

alionazherdetska commented Apr 28, 2025

After discussion in the dev roundtable, we've decided to close this PR and create a new ticket for the breakpoints utility implementation in the post-header component #5357.

Reasons:
This PR has been on hold for an extended period
There are now several merge conflicts that would be time-consuming to resolve
It would be more efficient to implement this from scratch with the current codebase

@github-project-automation github-project-automation bot moved this from 🧐 In Review to 🚀 Done in Design System Production Board Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 components Related to the @swisspost/design-system-components package Header Everything related to our composible header components
Projects
Development

Successfully merging a pull request may close this issue.

3 participants