Merge pull request swiftlang#74342 from slavapestov/flow-analysis-self-metatype-fix

SIL: Fix false positive in FlowIsolation with DynamicSelfType usage

Author: slavapestov

lib/SILOptimizer/Mandatory/FlowIsolation.cpp

@@ -582,6 +582,12 @@ void AnalysisInfo::analyze(const SILArgument *selfParam) {
   worklist.pushUsesOfValueIfNotVisited(selfParam);
 
   while (Operand *operand = worklist.pop()) {
+    // A type-dependent use of `self` is an instruction that contains the
+    // DynamicSelfType. These instructions do not access any protected
+    // state.
+    if (operand->isTypeDependent())
+      continue;
+
     SILInstruction *user = operand->getUser();
 
     // First, check if this is an apply that involves `self`

test/Concurrency/flow_isolation.swift

@@ -684,8 +684,7 @@ actor OhBrother {
   static var DefaultResult: Int { 10 }
 
   init() {
-    // expected-note@+2 {{after this closure involving 'self', only non-isolated properties of 'self' can be accessed from this init}}
-    // expected-warning@+1 {{cannot access property 'giver' here in non-isolated initializer; this is an error in the Swift 6 language mode}}
+    // this is OK: we're using DynamicSelfType but that doesn't access protected state.
     self.giver = { (x: OhBrother) -> Int in Self.DefaultResult }
   }