Merge pull request swiftlang#75963 from gottesmm/pr-fb279661a394bc36c6aea28f928d0c7e3adfdea4

[region-isolation] Tweak the logging to make it easier to quickly find the emitted error when triaging code.

Author: gottesmm

lib/SILOptimizer/Mandatory/TransferNonSendable.cpp

@@ -1253,8 +1253,8 @@ void TransferNonSendableImpl::emitUseAfterTransferDiagnostics() {
   if (transferOpToRequireInstMultiMap.empty())
     return;
 
-  REGIONBASEDISOLATION_LOG(llvm::dbgs()
-                           << "Emitting use after transfer diagnostics.\n");
+  REGIONBASEDISOLATION_LOG(
+      llvm::dbgs() << "Emitting Error. Kind: Use After Send diagnostics.\n");
 
   for (auto [transferOp, requireInsts] :
        transferOpToRequireInstMultiMap.getRange()) {
@@ -2030,8 +2030,8 @@ void TransferNonSendableImpl::emitTransferredNonTransferrableDiagnostics() {
   if (transferredNonTransferrableInfoList.empty())
     return;
 
-  REGIONBASEDISOLATION_LOG(
-      llvm::dbgs() << "Emitting transfer non transferrable diagnostics.\n");
+  REGIONBASEDISOLATION_LOG(llvm::dbgs()
+                           << "Emitting Error. Kind: Send Never Sendable.\n");
 
   for (auto info : transferredNonTransferrableInfoList) {
     TransferNonTransferrableDiagnosticInferrer diagnosticInferrer(
@@ -2434,7 +2434,7 @@ struct DiagnosticEvaluator final
     auto rep = info->getValueMap().getRepresentative(transferredVal);
     REGIONBASEDISOLATION_LOG(
         llvm::dbgs()
-        << "    Emitting Use After Transfer Error!\n"
+        << "    Emitting Error. Kind: Use After Send\n"
         << "        Transferring Inst: " << *transferringOp->getUser()
         << "        Transferring Op Value: " << transferringOp->get()
         << "        Require Inst: " << *partitionOp.getSourceInst()
@@ -2450,7 +2450,7 @@ struct DiagnosticEvaluator final
       const PartitionOp &partitionOp, Element transferredVal,
       SILDynamicMergedIsolationInfo isolationRegionInfo) const {
     REGIONBASEDISOLATION_LOG(
-        llvm::dbgs() << "    Emitting TransferNonTransferrable Error!\n"
+        llvm::dbgs() << "    Emitting Error. Kind: Send Non Sendable\n"
                      << "        ID:  %%" << transferredVal << "\n"
                      << "        Rep: "
                      << *info->getValueMap().getRepresentative(transferredVal)
@@ -2462,10 +2462,7 @@ struct DiagnosticEvaluator final
           auto name = inferNameHelper(isolatedValue);
           llvm::dbgs() << "        Isolated Value Name: "
                        << (name.has_value() ? name->get() : "none") << '\n';
-        } else {
-          llvm::dbgs() << "        Isolated Value: none\n";
-        }
-    );
+        } else { llvm::dbgs() << "        Isolated Value: none\n"; });
     auto *self = const_cast<DiagnosticEvaluator *>(this);
     auto nonTransferrableValue =
         info->getValueMap().getRepresentative(transferredVal);
@@ -2478,7 +2475,8 @@ struct DiagnosticEvaluator final
       const PartitionOp &partitionOp, Element inoutSendingVal,
       SILDynamicMergedIsolationInfo isolationRegionInfo) const {
     REGIONBASEDISOLATION_LOG(
-        llvm::dbgs() << "    Emitting InOut Sending ActorIsolated at end of "
+        llvm::dbgs() << "    Emitting Error. Kind: InOut Sending ActorIsolated "
+                        "at end of "
                         "Function Error!\n"
                      << "        ID:  %%" << inoutSendingVal << "\n"
                      << "        Rep: "
@@ -2500,7 +2498,7 @@ struct DiagnosticEvaluator final
       Element actualNonTransferrableValue,
       SILDynamicMergedIsolationInfo isolationRegionInfo) const {
     REGIONBASEDISOLATION_LOG(
-        llvm::dbgs() << "    Emitting TransferNonTransferrable Error!\n"
+        llvm::dbgs() << "    Emitting Error. Kind: Send Non Sendable\n"
                      << "        ID:  %%" << transferredVal << "\n"
                      << "        Rep: "
                      << *info->getValueMap().getRepresentative(transferredVal)
@@ -2545,7 +2543,7 @@ struct DiagnosticEvaluator final
     auto srcRep = info->getValueMap().getRepresentativeValue(srcElement);
     REGIONBASEDISOLATION_LOG(
         llvm::dbgs()
-        << "    Emitting Error! Kind: Assign Isolated Into Sending Result!\n"
+        << "    Emitting Error. Kind: Assign Isolated Into Sending Result!\n"
         << "        Assign Inst: " << *partitionOp.getSourceInst()
         << "        Dest Value: " << *destValue
         << "        Dest Element: " << destElement << '\n'
@@ -2564,7 +2562,8 @@ struct DiagnosticEvaluator final
     auto rep = info->getValueMap().getRepresentative(inoutSendingVal);
     REGIONBASEDISOLATION_LOG(
         llvm::dbgs()
-        << "    Emitting InOut Not Reinitialized At End Of Function!\n"
+        << "    Emitting Error. Kind: InOut Not Reinitialized At End Of "
+           "Function\n"
         << "        Transferring Inst: " << *transferringOp->getUser()
         << "        Transferring Op Value: " << transferringOp->get()
         << "        Require Inst: " << *partitionOp.getSourceInst()