Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Plan Implementation - Integration Tests: lsp integration #1235

Open
michael-weng opened this issue Dec 2, 2024 · 0 comments
Open

Test Plan Implementation - Integration Tests: lsp integration #1235

michael-weng opened this issue Dec 2, 2024 · 0 comments
Labels
needs verification Issue has been fixed, but requires verification before closing testing infrastructure Issues related to CI jobs or extension test cases

Comments

@michael-weng
Copy link
Contributor

  • Ensure the integration with sourcekit-lsp works as intended, with correct requests sent and responses received.
  • Detect potential changes in the LSP response for most essential request like go to definition and find all references.
michael-weng added a commit to michael-weng/vscode-swift that referenced this issue Dec 2, 2024
@michael-weng
Add basic lsp integration test to check language support
7c61028 
- Roll relevant test under language folder for better organization.
- Given how build all task for defaultPacakge will need to be executed
as a set up for this test, remove @slow for other tests that's running
this task as the cost will be atmortized in CI.
- The test check lsp client is running and exercise Goto Definition
Request and Find References Request.

Issue: swiftlang#1235
@michael-weng michael-weng mentioned this issue Dec 2, 2024
Closed
michael-weng added a commit to michael-weng/vscode-swift that referenced this issue Dec 2, 2024
@michael-weng
Add basic lsp integration test to check language support
b327915 
- Roll relevant test under language folder for better organization.
- Given how build all task for defaultPacakge will need to be executed
as a set up for this test, remove @slow for other tests that's running
this task as the cost will be atmortized in CI.
- The test check lsp client is running and exercise Goto Definition
Request and Find References Request.

Issue: swiftlang#1235
@award999 award999 added the testing infrastructure Issues related to CI jobs or extension test cases label Dec 3, 2024
@award999 award999 moved this from Unscreened to In Progress in Swift Extension for Visual Studio Code Dec 3, 2024
@michael-weng michael-weng mentioned this issue Dec 3, 2024
Closed
michael-weng added a commit to michael-weng/vscode-swift that referenced this issue Dec 3, 2024
@michael-weng
Add basic lsp integration test to check language support
34c4d9c 
- Roll relevant test under language folder for better organization.
- Given how build all task for defaultPacakge will need to be executed
as a set up for this test, remove @slow for other tests that's running
this task as the cost will be atmortized in CI.
- The test check lsp client is running and exercise Goto Definition
Request and Find References Request.

Issue: swiftlang#1235
@award999 award999 moved this from In Progress to Needs Verification in Swift Extension for Visual Studio Code Dec 12, 2024
@award999 award999 added the needs verification Issue has been fixed, but requires verification before closing label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs verification Issue has been fixed, but requires verification before closing testing infrastructure Issues related to CI jobs or extension test cases
Projects
Swift Extension for Visual Studio Code
Status: Needs Verification
Milestone
No milestone
Development

No branches or pull requests
2 participants
@award999 @michael-weng