Remove use of NSString.replacingOccurrences(of:with:)

Prefer to use `String.replacing(_:with:)` instead of the `NSString`
operations for the strings.  This should avoid an unnecessary use of
Foundation API and a dispatch to the `NSString` API.

Author: compnerd

Sources/Basics/FileSystem/AbsolutePath.swift

@@ -321,7 +321,7 @@ extension AbsolutePath {
 
 extension AbsolutePath {
     public func escapedPathString() -> String {
-        self.pathString.replacingOccurrences(of: "\\", with: "\\\\")
+        self.pathString.replacing("\\", with: "\\\\")
     }
 }
 

Sources/Basics/NativePathExtensions.swift

@@ -18,7 +18,7 @@ extension AbsolutePath {
         return URL(fileURLWithPath: self.pathString).withUnsafeFileSystemRepresentation {
             let repr = String(cString: $0!)
             if escaped {
-                return repr.replacingOccurrences(of: "\\", with: "\\\\")
+                return repr.replacing("\\", with: "\\\\")
             }
             return repr
         }

Sources/Basics/Netrc.swift

@@ -133,7 +133,7 @@ public struct NetrcParser {
         var trimmedCommentsText = text
         matches.forEach {
             trimmedCommentsText = trimmedCommentsText
-                .replacingOccurrences(of: nsString.substring(with: $0.range), with: "")
+                .replacing(nsString.substring(with: $0.range), with: "")
         }
         return trimmedCommentsText
     }

Sources/Basics/Sandbox.swift

@@ -223,8 +223,8 @@ extension AbsolutePath {
     /// Private computed property that returns a version of the path as a string quoted for use as a subpath in a .sb sandbox profile.
     fileprivate var quotedAsSubpathForSandboxProfile: String {
         "\"" + self.pathString
-            .replacingOccurrences(of: "\\", with: "\\\\")
-            .replacingOccurrences(of: "\"", with: "\\\"")
+            .replacing("\\", with: "\\\\")
+            .replacing("\"", with: "\\\"")
             + "\""
     }
 }

Sources/Basics/macOS+CompatibilityShims.swift

@@ -0,0 +1,19 @@
+//===----------------------------------------------------------------------===//
+//
+// This source file is part of the Swift open source project
+//
+// Copyright (c) 2022 Apple Inc. and the Swift project authors
+// Licensed under Apache License v2.0 with Runtime Library Exception
+//
+// See http://swift.org/LICENSE.txt for license information
+// See http://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
+//
+//===----------------------------------------------------------------------===//
+
+#if os(macOS)
+extension String {
+    internal func replacing(_ target: String, with replacement: String) -> String {
+        target.replacingOccurrences(of: target, with: replacement)
+    }
+}
+#endif

Sources/Commands/Utilities/DOTManifestSerializer.swift

@@ -38,8 +38,8 @@ public struct DOTManifestSerializer {
 
     /// Quote the name and escape the quotes and backslashes
     func quoteName(_ name: String) -> String {
-        return "\"" + name.replacingOccurrences(of: "\"", with: "\\\"")
-                          .replacingOccurrences(of: "\\", with: "\\\\") + "\""
+        return "\"" + name.replacing("\"", with: "\\\"")
+                          .replacing("\\", with: "\\\\") + "\""
     }
 
     public mutating func writeDOT(to stream: OutputByteStream) {

Sources/Commands/macOS+CompatibilityShims.swift

@@ -0,0 +1 @@
+../Basics/macOS+CompatibilityShims.swift

Sources/PackageLoading/ManifestLoader.swift

@@ -766,7 +766,7 @@ public final class ManifestLoader: ManifestLoaderProtocol {
                         // Run the compiled manifest.
                         var environment = ProcessEnv.vars
                         #if os(Windows)
-                        let windowsPathComponent = runtimePath.pathString.replacingOccurrences(of: "/", with: "\\")
+                        let windowsPathComponent = runtimePath.pathString.replacing("/", with: "\\")
                         environment["Path"] = "\(windowsPathComponent);\(environment["Path"] ?? "")"
                         #endif
 

Sources/PackageLoading/ModuleMapGenerator.swift

@@ -19,7 +19,7 @@ public let moduleMapFilename = "module.modulemap"
 
 extension AbsolutePath {
   fileprivate var moduleEscapedPathString: String {
-    return self.pathString.replacingOccurrences(of: "\\", with: "\\\\")
+    return self.pathString.replacing("\\", with: "\\\\")
   }
 }
 

Sources/PackageLoading/macOS+CompatibilityShims.swift

@@ -0,0 +1 @@
+../Basics/macOS+CompatibilityShims.swift

Sources/PackageModel/ManifestSourceGeneration.swift

@@ -681,8 +681,8 @@ extension TargetBuildSettingDescription.Kind {
 extension String {
     fileprivate var quotedForPackageManifest: String {
         return "\"" + self
-            .replacingOccurrences(of: "\\", with: "\\\\")
-            .replacingOccurrences(of: "\"", with: "\\\"")
+            .replacing("\\", with: "\\\\")
+            .replacing("\"", with: "\\\"")
             + "\""
     }
 }

Sources/PackageModel/macOS+CompatibilityShims.swift

@@ -0,0 +1 @@
+../Basics/macOS+CompatibilityShims.swift

Sources/PackageRegistry/RegistryClient.swift

@@ -2165,7 +2165,7 @@ extension HTTPClientHeaders {
             return nil
         }
 
-        return parts[1].replacingOccurrences(of: "\"", with: "")
+        return parts[1].replacing("\"", with: "")
     }
 }
 

Sources/PackageRegistry/macOS+CompatibilityShims.swift

@@ -0,0 +1 @@
+../Basics/macOS+CompatibilityShims.swift

Sources/SourceControl/GitRepository.swift

@@ -775,7 +775,7 @@ public final class GitRepository: Repository, WorkingCheckout {
             }
 
             return stringPaths.map(output.split(separator: "\n").map {
-                let string = String($0).replacingOccurrences(of: "\\\\", with: "\\")
+                let string = String($0).replacing("\\\\", with: "\\")
                 if string.utf8.first == UInt8(ascii: "\"") {
                     return String(string.dropFirst(1).dropLast(1))
                 }

Sources/SourceControl/macOS+CompatibilityShims.swift

@@ -0,0 +1 @@
+../Basics/macOS+CompatibilityShims.swift