swift-format still can't treat unsafe expressions correctly in some cases

[kkebo]

Thanks for fixing #972. However, it seems that swift-format still can't treat unsafe expressions correctly in some cases. The cases are when a l-value is unsafe.

Input

let ptr: UnsafePointer<UInt8>?
// comment
unsafe ptr = .init(bitPattern: 0)
print(ptr)

Expected result

let ptr: UnsafePointer<UInt8>?
// comment
unsafe ptr = .init(bitPattern: 0)
print(ptr)

Actual result

let ptr: UnsafePointer<UInt8>?
// comment

// comment
unsafe ptr = .init(bitPattern: 0)
print(ptr)

Environment

• swift-format: 58807b9
• swift-syntax: 820501e3cf5894ad1deb8de95649b938a8bbe9f4

[TTOzzi]

I think this might be an issue with swift-syntax 🤔

[TTOzzi]

I've opened a PR with the fix here swiftlang/swift-syntax#3043!

[ahoppen]

Synced to Apple’s issue tracker as rdar://148657851

[kkebo]

I've confirmed that swift-format's format mode have been fixed thanks to swiftlang/swift-syntax#3043.

However, its lint mode is still broken. Here is how to reproduce the issue.

Input (test.swift)

let ptr: UnsafePointer<UInt8>?
// comment
unsafe ptr = .init(bitPattern: 0)
print(ptr)

.swift-format

{
  "rules" : {
    "NoAssignmentInExpressions" : true
  },
  "version" : 1
}

Steps to reproduce

1. Create test.swift
2. Create .swift-format
3. Run swift format lint test.swift

Expected result

(no warnings)

Actual result

test.swift:3:8: warning: [NoAssignmentInExpressions] move this assignment expression into its own statement
test.swift:3:8: warning: [NoAssignmentInExpressions] move this assignment expression into its own statement

[kkebo]

I've created a PR: #1021