Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SourceKit-LSP not publishing diagnostics on Windows #1855

Closed
award999 opened this issue Dec 5, 2024 · 1 comment · Fixed by #1880
Closed

SourceKit-LSP not publishing diagnostics on Windows #1855

award999 opened this issue Dec 5, 2024 · 1 comment · Fixed by #1880
Labels
bug Something isn't working Windows Windows platform support

Comments

@award999
Copy link

award999 commented Dec 5, 2024

Swift version

Swift version 6.0.2 (swift-6.0.2-RELEASE)

Platform

Windows 11

Editor

vscode-swift extension

Description

swiftlang/vscode-swift#1226 was reported to vscode-swift repo. I am able to reproduce it on Windows with both the ARM64 and x86_64 toolchains downloaded off swift.org. Finding references and go to definition requests are working, the vscode-swift extension just isn't getting diagnostics.

Steps to Reproduce

  1. Open a project in the vscode-swift extension
  2. Write some bad code that should produce a compiler error:
let f =1
f = 2
  1. Notice that no diagnostics show
  2. Run a vscode build task and see that the swiftc diagnostics show up
  3. Fix the error, notice it doesn't get cleared

Logging

attached log for simple project created with "swift init"
sourcekit-lsp diagnostics.zip
@award999 award999 added bug Something isn't working Windows Windows platform support labels Dec 5, 2024
@award999 award999 mentioned this issue Dec 5, 2024
Closed
@ahoppen
Copy link
Member

ahoppen commented Dec 5, 2024

Synced to Apple’s issue tracker as rdar://141001203

ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this issue Dec 10, 2024
@ahoppen
Normalize Windows drive letter to be uppercase
17c143d 
VS Code spells file paths with a lowercase drive letter, while the rest of Windows APIs use an uppercase drive letter. Normalize the drive letter spelling to be uppercase.

Fixes swiftlang#1855
rdar://141001203
@ahoppen ahoppen mentioned this issue Dec 10, 2024
Merged
ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this issue Dec 11, 2024
@ahoppen
Normalize Windows drive letter to be uppercase
8eab52c 
VS Code spells file paths with a lowercase drive letter, while the rest of Windows APIs use an uppercase drive letter. Normalize the drive letter spelling to be uppercase.

Fixes swiftlang#1855
rdar://141001203
ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this issue Dec 11, 2024
@ahoppen
Normalize Windows drive letter to be uppercase
53df6b2 
VS Code spells file paths with a lowercase drive letter, while the rest of Windows APIs use an uppercase drive letter. Normalize the drive letter spelling to be uppercase.

Fixes swiftlang#1855
rdar://141001203
@ahoppen ahoppen mentioned this issue Dec 11, 2024
Open
ahoppen added a commit to ahoppen/sourcekit-lsp that referenced this issue Dec 11, 2024
@ahoppen
Normalize Windows drive letter to be uppercase
9fa5200 
VS Code spells file paths with a lowercase drive letter, while the rest of Windows APIs use an uppercase drive letter. Normalize the drive letter spelling to be uppercase.

Fixes swiftlang#1855
rdar://141001203
@plemarquand plemarquand mentioned this issue Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Windows Windows platform support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Normalize Windows drive letter to be uppercase ahoppen/sourcekit-lsp
2 participants
@ahoppen @award999