Skip to content

Commit 58dfa69

Browse files
committed
Actually test spans
1 parent a8141b6 commit 58dfa69

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

lldb/source/Plugins/Language/Swift/SwiftUnsafeTypes.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -466,11 +466,12 @@ std::unique_ptr<SwiftUnsafeType> SwiftUnsafeType::Create(ValueObject &valobj) {
466466

467467
llvm::StringRef valobj_type_name(type.GetTypeName().GetCString());
468468
valobj_type_name.consume_front("Swift.");
469-
if (valobj_type_name.consume_front("Span"))
469+
bool is_unsafe = valobj_type_name.consume_front("Unsafe");
470+
valobj_type_name.consume_front("Mutable");
471+
472+
if (!is_unsafe && valobj_type_name.consume_front("Span"))
470473
return std::make_unique<SwiftSpan>(valobj);
471474

472-
valobj_type_name.consume_front("Unsafe");
473-
valobj_type_name.consume_front("Mutable");
474475
bool is_raw = valobj_type_name.consume_front("Raw");
475476
bool is_buffer_ptr = valobj_type_name.consume_front("Buffer");
476477
UnsafePointerKind kind =
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
SWIFT_SOURCES := main.swift
2-
SWIFTFLAGS_EXTRAS := -parse-as-library
2+
SWIFTFLAGS_EXTRAS := -parse-as-library -Xfrontend -disable-availability-checking
33
include Makefile.rules

lldb/test/API/lang/swift/span/TestSwiftSpan.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ def test(self):
1313
self, "break here", lldb.SBFileSpec("main.swift")
1414
)
1515

16-
self.expect("frame var ints", substrs=["2 values", "[0] = 6", "[1] = 7"])
17-
self.expect(
18-
"frame var strings", substrs=["2 values", '[0] = "six"', '[1] = "seven"']
19-
)
20-
self.expect(
21-
"frame var things", substrs=["1 value", "[0] = (id = 67, odd = true)"]
22-
)
16+
self.expect("frame var ints_span", substrs=["[0] = 6", "[1] = 7"])
17+
self.expect("frame var strings_span", substrs=['[0] = "six"', '[1] = "seven"'])
18+
self.expect("frame var things_span", substrs=["[0] = (id = 67, odd = true)"])

lldb/test/API/lang/swift/span/main.swift

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,11 @@ struct Thing {
1111
@main struct Entry {
1212
static func main() {
1313
let ints = [6, 7]
14+
let ints_span = ints.span
1415
let strings = ["six", "seven"]
16+
let strings_span = strings.span
1517
let things = [Thing(67)]
18+
let things_span = things.span
1619
print("break here")
1720
}
1821
}

0 commit comments

Comments
 (0)