Skip to content

Commit d8354eb

Browse files
committed
Sync with upstream script to properly handle symlinks
1 parent 9576a06 commit d8354eb

File tree

3 files changed

+40
-26
lines changed

3 files changed

+40
-26
lines changed

sysroot/generated_package_lists/bullseye.amd64

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/gcc-10/l
22
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/gcc-10/libgcc-s1_10.2.1-6_amd64.deb
33
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/gcc-10/libstdc++-10-dev_10.2.1-6_amd64.deb
44
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/gcc-10/libstdc++6_10.2.1-6_amd64.deb
5-
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/glibc/libc6_2.31-13+deb11u5_amd64.deb
65
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/glibc/libc6-dev_2.31-13+deb11u5_amd64.deb
7-
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/libblas3_3.9.0-3_amd64.deb
6+
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/glibc/libc6_2.31-13+deb11u5_amd64.deb
87
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/libblas-dev_3.9.0-3_amd64.deb
9-
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/liblapack3_3.9.0-3_amd64.deb
8+
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/libblas3_3.9.0-3_amd64.deb
109
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/liblapack-dev_3.9.0-3_amd64.deb
10+
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/liblapack3_3.9.0-3_amd64.deb
1111
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/linux/linux-libc-dev_6.1.12-1~bpo11+1_amd64.deb
1212
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/u/util-linux/uuid-dev_2.36.1-8+deb11u1_amd64.deb

sysroot/generated_package_lists/bullseye.arm64

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/gcc-10/l
22
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/gcc-10/libgcc-s1_10.2.1-6_arm64.deb
33
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/gcc-10/libstdc++-10-dev_10.2.1-6_arm64.deb
44
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/gcc-10/libstdc++6_10.2.1-6_arm64.deb
5-
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/glibc/libc6_2.31-13+deb11u5_arm64.deb
65
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/glibc/libc6-dev_2.31-13+deb11u5_arm64.deb
7-
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/libblas3_3.9.0-3_arm64.deb
6+
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/g/glibc/libc6_2.31-13+deb11u5_arm64.deb
87
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/libblas-dev_3.9.0-3_arm64.deb
9-
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/liblapack3_3.9.0-3_arm64.deb
8+
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/libblas3_3.9.0-3_arm64.deb
109
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/liblapack-dev_3.9.0-3_arm64.deb
10+
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/lapack/liblapack3_3.9.0-3_arm64.deb
1111
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/l/linux/linux-libc-dev_6.1.12-1~bpo11+1_arm64.deb
1212
https://snapshot.debian.org/archive/debian/20230329T085712Z/pool/main/u/util-linux/uuid-dev_2.36.1-8+deb11u1_arm64.deb

sysroot/sysroot-creator.sh

Lines changed: 34 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,16 @@
1111
#@ {amd64,i386,armhf,arm64,armel,mipsel,mips64el}
1212
#@
1313

14+
# partially synced with https://chromium.googlesource.com/chromium/src/+/e8df45bfd5386216b9b6ff178b26461902c7ae3a/build/linux/sysroot_scripts/sysroot-creator.sh
15+
16+
1417
######################################################################
1518
# Config
1619
######################################################################
1720

1821
set -o nounset
1922
set -o errexit
23+
set -x
2024

2125
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
2226

@@ -450,35 +454,45 @@ InstallIntoSysroot() {
450454

451455
CleanupJailSymlinks() {
452456
Banner "Jail symlink cleanup"
453-
454457
SAVEDPWD=$(pwd)
455458
cd ${INSTALL_ROOT}
456459
local libdirs="lib usr/lib"
457-
if [ -d lib64 ]; then
460+
if [ "${ARCH}" != "MIPS" ]; then
458461
libdirs="${libdirs} lib64"
459462
fi
460-
461463
find $libdirs -type l -printf '%p %l\n' | while read link target; do
464+
echo "Processing link ${link} -> ${target}"
462465
# skip links with non-absolute paths
463466
echo "${target}" | grep -qs ^/ || continue
464467
echo "${link}: ${target}"
465-
# Relativize the symlink.
466-
prefix=$(echo "${link}" | sed -e 's/[^/]//g' | sed -e 's|/|../|g')
467-
ln -snfv "${prefix}${target}" "${link}"
468+
case "${link}" in
469+
usr/lib/gcc/*-linux-gnu/4.*/* | usr/lib/gcc/arm-linux-gnueabihf/4.*/* | \
470+
usr/lib/gcc/aarch64-linux-gnu/4.*/*)
471+
# Relativize the symlink.
472+
ln -snfv "../../../../..${target}" "${link}"
473+
;;
474+
usr/lib/*-linux-gnu/* | usr/lib/arm-linux-gnueabihf/*)
475+
# Relativize the symlink.
476+
ln -snfv "../../..${target}" "${link}"
477+
;;
478+
usr/lib/*)
479+
# Relativize the symlink.
480+
ln -snfv "../..${target}" "${link}"
481+
;;
482+
lib64/* | lib/*)
483+
# Relativize the symlink."
484+
ln -snfv "..${target}" "${link}"
485+
;;
486+
esac
468487
done
469-
470-
failed=0
471-
while read link target; do
472-
# Make sure we catch new bad links.
473-
if [ ! -r "${link}" ]; then
474-
echo "ERROR: FOUND BAD LINK ${link}"
475-
ls -l ${link}
476-
failed=1
477-
fi
478-
done < <(find $libdirs -type l -printf '%p %l\n')
479-
if [ $failed -eq 1 ]; then
480-
exit 1
481-
fi
488+
# find $libdirs -type l -printf '%p %l\n' | while read link target; do
489+
# # Make sure we catch new bad links.
490+
# if [ ! -r "${link}" ]; then
491+
# echo "ERROR: FOUND BAD LINK ${link}"
492+
# ls -l ${link}
493+
# exit 1
494+
# fi
495+
# done
482496
cd "$SAVEDPWD"
483497
}
484498

@@ -513,7 +527,7 @@ BuildSysroot() {
513527
StripChecksumsFromPackageList "$package_file"
514528
InstallIntoSysroot ${files_and_sha256sums}
515529
HacksAndPatches
516-
# CleanupJailSymlinks
530+
CleanupJailSymlinks
517531
# VerifyLibraryDeps
518532
CreateTarBall
519533
}

0 commit comments

Comments
 (0)