Skip to content

Default values shall not be pre-divided by sample-rate #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JohannesLorenz opened this issue Nov 13, 2020 · 0 comments
Open

Default values shall not be pre-divided by sample-rate #17

JohannesLorenz opened this issue Nov 13, 2020 · 0 comments

Comments

@JohannesLorenz
Copy link

Example from the generated GLAME Butterworth Lowpass ttl:

 :port [
     a :InputPort, :ControlPort ;
     :name "Cutoff Frequency (Hz)" ;
     :index 0 ;
     :symbol "cutoff" ;
     :minimum 0.0001 ;
     :maximum 0.45 ;
     
     :default 0.112575 ;
     :portProperty pprops:logarithmic ;
     :portProperty :sampleRate ;
   ] ;

Here, sampleRate tells us that minimum and maximum shall be multiplied with the processing sample rate, i.e. minimum and maximum in range [0,1] makes sense. However, default will not be multiplied, so the default value must be in range [minimum*sampleRate, maximum*sampleRate].

Thanks for @PhysSong who posted a comment about it, and to @drobilla for confirming that this default value is not valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant