Conversation
|
Binary Sizes
Commit: aa68740 |
Merging this PR will not alter performance
Comparing Footnotes
|
ReviewDocumentation-only change to MSRV rule (root
|
There was a problem hiding this comment.
Pull request overview
This PR updates repository guidance for automated and human contributors so future changes stay within SWC’s supported Rust compatibility range and add minifier regressions to the preferred fixture suites. It fits the codebase by refining the project’s existing AGENTS.md instructions rather than changing runtime behavior.
Changes:
- Add a repository-wide instruction to respect the project’s Rust MSRV when writing new Rust code.
- Clarify
swc_ecma_minifierfixture guidance by removingtests/terserfrom preferred roots for new regression additions. - Direct new minifier regression coverage toward SWC-owned fixtures such as
tests/fixture/issues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
AGENTS.md |
Adds top-level contributor guidance to keep new Rust code compatible with the project MSRV. |
crates/swc_ecma_minifier/AGENTS.md |
Refines crate-specific testing guidance so new regressions go into SWC-owned fixture suites instead of tests/terser. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description:
Adds agent guidance requested from PR review feedback:
This is documentation-only and helps future automated edits choose the right compatibility and fixture behavior.
BREAKING CHANGE:
None.
Related issue (if exists):
Refs #11830 (comment)