[CSharp] Issue with double numbers if local is not US

[lunat]

Hi,

I am using codegen 2.3.0.

In file ApiClient, the Method
public string ParameterToString(object obj)
contains an error at row:

swagger-codegen/modules/swagger-codegen/src/main/resources/csharp/ApiClient.mustache

Line 311 in c6b6249

return Convert.ToString (obj);

If I use a localization different from "US" and I have a double value this row returns a number with a comma "," instead dot "."

I think it should be better to return always the "dotted" number adding another "else if" condition:

    else if (obj is double || obj is decimal)
    {
        return Convert.ToString(obj, new CultureInfo("en-US"));
    }

Thanks,

lunat

[jimschubert]

@lunat this sounds like a reasonable fix to me. Are you able to submit a PR and verify that it has resolved your issue?

[wing328]

@lunat @jimschubert should the users change the localization setting instead in his/her PC?

[jimschubert]

@wing328 It's not really reasonable to expect every client consumer to change their machine locale to en-US. Ideally, the format would be a configurable option in the spec, but the spec doesn't support that, as far as I'm aware.

I would think the best approach for now is to the input/output format for the API is a known format.

We may want to consider supporting global formatting configurations (number, currency, date) and then supporting per-operation formatting. What are your thoughts with that approach?