[PHP] Separate `host` into `host` and `basePath`

[ackintosh]

Description

Problem

swagger: "2.0"
info:
  title: TEST API
  version: ""
host: aaa.example.com
basePath: /private

$c = new Swagger\Client\Configuration();

$c->getHost();// string "http://aaa.example.com/private"

// `/private` WILL BE LOST...
$c->setHost('http://bbb.example.com');

$c->getHost();// string "http://bbb.example.com"

$api = new Swagger\Client\Api\TestApi(null, $c);
$api->getXXX();
// 404 Not Found

I'd like to improve Configuration as follows.

• new methods
  • Configuration::setBasePath()
  • Configuration::getBasePath()
  • Configuration::getBaseUrl()

/*
 * setter
 */
// Only the `host` is changed.
$c->setHost('http://bbb.example.com');
// If we want to change the `basePath`, like this.
$c->setBasePath('/public');

/*
 * getter
 */
$c->getHost();
// string "http://bbb.example.com"
$c->getBasePath();
// string "/public"
$c->getBaseUrl();
// string "http://bbb.example.com/public"

Swagger-codegen version

2.3.0

---

Please let me know what you think.
Thank you.

[wing328]

@ackintosh thanks for the suggestion.

cc @baartosz, @arnested @dkarlovi for feedback.

[wing328]

FYI. Python, JS are following the same convention as PHP.

https://github.com/swagger-api/swagger-codegen/blob/master/samples/client/petstore/python/petstore_api/configuration.py#L48

https://github.com/swagger-api/swagger-codegen/blob/master/samples/client/petstore/javascript/src/ApiClient.js#L52

I think your suggestion is more similar to the Ruby approach: https://github.com/swagger-api/swagger-codegen/blob/master/samples/client/petstore/ruby/lib/petstore/configuration.rb#L131-L133

[ackintosh]

Yes!
I think that it is better to match API definition key(host, basePath) and Configuration class interface(setXXX(), getXXX()) to prevent developers from getting confused.