Skip to content

Commit 95b9190

Browse files
authored
Merge pull request #155 from gcotelli/master
Make Zinc load in newer Pharo images again without running previous code or using Metacello trickery
2 parents c4b45be + f50943a commit 95b9190

4 files changed

Lines changed: 16 additions & 7 deletions

File tree

.smalltalk.ston

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,8 @@
11
SmalltalkCISpec {
22
#loading : [
3-
SCIMetacelloLoadSpec {
4-
#baseline : 'Zodiac',
5-
#repository: 'github://svenvc/zodiac/repository',
6-
#ignoreImage : true,
7-
#platforms : [ #pharo ]
8-
},
93
SCIMetacelloLoadSpec {
104
#baseline : 'ZincHTTPComponents',
115
#directory: 'repository',
12-
#ignoreImage : true,
136
#platforms : [ #pharo ]
147
}
158
]

repository/BaselineOfZincHTTPComponents.package/BaselineOfZincHTTPComponents.class/instance/baseline..st

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
baselines
22
baseline: spec
33
<baseline>
4+
self unloadBaselineOfZodiac.
45
spec for: #common do: [
56
spec
67
baseline: 'Zodiac' with: [ spec repository: 'github://svenvc/zodiac:master/repository' ];
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
baselines
2+
projectClass
3+
4+
^ MetacelloCypressBaselineProject
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
doits
2+
unloadBaselineOfZodiac
3+
"Newer Pharo versions includes an erroneous BaselineOfZodiac that breaks Zinc loading.
4+
So, we remove this baseline to not take precedence over the one that Zinc will load and
5+
avoiding magic tricks in the dependent projects.
6+
Side note:
7+
In Pharo 7 `MCWorkingCopy>>hasPackageNamed:` returns the class instead of a
8+
boolean 🤦"
9+
(((MCWorkingCopy hasPackageNamed: 'BaselineOfZodiac') == true)
10+
and: [ MCWorkingCopy respondsTo: #forPackageNamed: ])
11+
ifTrue: [ (MCWorkingCopy forPackageNamed: 'BaselineOfZodiac') unload ]

0 commit comments

Comments
 (0)