feat(prefer-svelte-reactivity): added rule implementation

Author: marekdedic

.changeset/rich-colts-nail.md

@@ -0,0 +1,5 @@
+---
+'eslint-plugin-svelte': minor
+---
+
+feat: added the `prefer-svelte-reactivity` rule

README.md

@@ -273,6 +273,7 @@ These rules relate to possible syntax or logic errors in Svelte code:
 | [svelte/no-store-async](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-store-async/) | disallow using async/await inside svelte stores because it causes issues with the auto-unsubscribing features | :star: |
 | [svelte/no-top-level-browser-globals](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-top-level-browser-globals/) | disallow using top-level browser global variables |  |
 | [svelte/no-unknown-style-directive-property](https://sveltejs.github.io/eslint-plugin-svelte/rules/no-unknown-style-directive-property/) | disallow unknown `style:property` | :star: |
+| [svelte/prefer-svelte-reactivity](https://sveltejs.github.io/eslint-plugin-svelte/rules/prefer-svelte-reactivity/) | disallow using built-in classes where a reactive alternative is provided by svelte/reactivity | :star: |
 | [svelte/require-store-callbacks-use-set-param](https://sveltejs.github.io/eslint-plugin-svelte/rules/require-store-callbacks-use-set-param/) | store callbacks must use `set` param | :bulb: |
 | [svelte/require-store-reactive-access](https://sveltejs.github.io/eslint-plugin-svelte/rules/require-store-reactive-access/) | disallow to use of the store itself as an operand. Need to use $ prefix or get function. | :star::wrench: |
 | [svelte/valid-compile](https://sveltejs.github.io/eslint-plugin-svelte/rules/valid-compile/) | disallow warnings when compiling. |  |

docs/rules.md

@@ -30,6 +30,7 @@ These rules relate to possible syntax or logic errors in Svelte code:
 | [svelte/no-store-async](./rules/no-store-async.md)                                               | disallow using async/await inside svelte stores because it causes issues with the auto-unsubscribing features                          | :star:         |
 | [svelte/no-top-level-browser-globals](./rules/no-top-level-browser-globals.md)                   | disallow using top-level browser global variables                                                                                      |                |
 | [svelte/no-unknown-style-directive-property](./rules/no-unknown-style-directive-property.md)     | disallow unknown `style:property`                                                                                                      | :star:         |
+| [svelte/prefer-svelte-reactivity](./rules/prefer-svelte-reactivity.md)                           | disallow using built-in classes where a reactive alternative is provided by svelte/reactivity                                          | :star:         |
 | [svelte/require-store-callbacks-use-set-param](./rules/require-store-callbacks-use-set-param.md) | store callbacks must use `set` param                                                                                                   | :bulb:         |
 | [svelte/require-store-reactive-access](./rules/require-store-reactive-access.md)                 | disallow to use of the store itself as an operand. Need to use $ prefix or get function.                                               | :star::wrench: |
 | [svelte/valid-compile](./rules/valid-compile.md)                                                 | disallow warnings when compiling.                                                                                                      |                |

packages/eslint-plugin-svelte/src/configs/flat/recommended.ts

@@ -37,6 +37,7 @@ const config: Linter.Config[] = [
 			'svelte/no-unused-svelte-ignore': 'error',
 			'svelte/no-useless-children-snippet': 'error',
 			'svelte/no-useless-mustaches': 'error',
+			'svelte/prefer-svelte-reactivity': 'error',
 			'svelte/prefer-writable-derived': 'error',
 			'svelte/require-each-key': 'error',
 			'svelte/require-event-dispatcher-types': 'error',

packages/eslint-plugin-svelte/src/rule-types.ts

@@ -316,6 +316,11 @@ export interface RuleOptions {
    * @see https://sveltejs.github.io/eslint-plugin-svelte/rules/prefer-style-directive/
    */
   'svelte/prefer-style-directive'?: Linter.RuleEntry<[]>
+  /**
+   * disallow using built-in classes where a reactive alternative is provided by svelte/reactivity
+   * @see https://sveltejs.github.io/eslint-plugin-svelte/rules/prefer-svelte-reactivity/
+   */
+  'svelte/prefer-svelte-reactivity'?: Linter.RuleEntry<[]>
   /**
    * Prefer using writable $derived instead of $state and $effect
    * @see https://sveltejs.github.io/eslint-plugin-svelte/rules/prefer-writable-derived/

packages/eslint-plugin-svelte/src/rules/prefer-svelte-reactivity.ts

@@ -0,0 +1,65 @@
+import { ReferenceTracker } from '@eslint-community/eslint-utils';
+import { createRule } from '../utils/index.js';
+
+export default createRule('prefer-svelte-reactivity', {
+	meta: {
+		docs: {
+			description:
+				'disallow using built-in classes where a reactive alternative is provided by svelte/reactivity',
+			category: 'Possible Errors',
+			recommended: true
+		},
+		schema: [],
+		messages: {
+			dateUsed: 'Found a usage of the built-in Date class. Use a SvelteDate instead.',
+			mapUsed: 'Found a usage of the built-in Map class. Use a SvelteMap instead.',
+			setUsed: 'Found a usage of the built-in Set class. Use a SvelteSet instead.',
+			urlUsed: 'Found a usage of the built-in URL class. Use a SvelteURL instead.',
+			urlSearchParamsUsed:
+				'Found a usage of the built-in URLSearchParams class. Use a SvelteURLSearchParams instead.'
+		},
+		type: 'problem', // 'problem', or 'layout',
+		conditions: [
+			{
+				svelteVersions: ['5'],
+				svelteFileTypes: ['.svelte', '.svelte.[js|ts]']
+			}
+		]
+	},
+	create(context) {
+		return {
+			Program() {
+				const referenceTracker = new ReferenceTracker(context.sourceCode.scopeManager.globalScope!);
+				for (const { node, path } of referenceTracker.iterateGlobalReferences({
+					Date: {
+						[ReferenceTracker.CONSTRUCT]: true
+					},
+					Map: {
+						[ReferenceTracker.CONSTRUCT]: true
+					},
+					Set: {
+						[ReferenceTracker.CONSTRUCT]: true
+					},
+					URL: {
+						[ReferenceTracker.CONSTRUCT]: true
+					},
+					URLSearchParams: {
+						[ReferenceTracker.CONSTRUCT]: true
+					}
+				})) {
+					const typeToMessageId: Record<string, string> = {
+						Date: 'dateUsed',
+						Map: 'mapUsed',
+						Set: 'setUsed',
+						URL: 'urlUsed',
+						URLSearchParams: 'urlSearchParamsUsed'
+					};
+					context.report({
+						messageId: typeToMessageId[path[0]],
+						node
+					});
+				}
+			}
+		};
+	}
+});

packages/eslint-plugin-svelte/src/utils/rules.ts

@@ -62,6 +62,7 @@ import preferClassDirective from '../rules/prefer-class-directive.js';
 import preferConst from '../rules/prefer-const.js';
 import preferDestructuredStoreProps from '../rules/prefer-destructured-store-props.js';
 import preferStyleDirective from '../rules/prefer-style-directive.js';
+import preferSvelteReactivity from '../rules/prefer-svelte-reactivity.js';
 import preferWritableDerived from '../rules/prefer-writable-derived.js';
 import requireEachKey from '../rules/require-each-key.js';
 import requireEventDispatcherTypes from '../rules/require-event-dispatcher-types.js';
@@ -141,6 +142,7 @@ export const rules = [
 	preferConst,
 	preferDestructuredStoreProps,
 	preferStyleDirective,
+	preferSvelteReactivity,
 	preferWritableDerived,
 	requireEachKey,
 	requireEventDispatcherTypes,