You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As noted in #182, the only thing the coil filament data is used for in MagnetSetFromGeometry() is so the radial distance utilities work with both subclasses. Removing the coil filament data from MagnetSetFromGeometry() and updating the radial distance utilities so it will work with both subclasses seems to make sense from a separation of concerns point of view.
The text was updated successfully, but these errors were encountered:
No I haven't started working on this yet, it also might not be necessary since if a user has the filament data to generate the surface we fire rays at they could just use MagnetSetFromFilaments() if they need to do radial distance finding. At the time I made this issue I felt that both classes should work with all parts of parastell but maybe that isn't the case?
As noted in #182, the only thing the coil filament data is used for in MagnetSetFromGeometry() is so the radial distance utilities work with both subclasses. Removing the coil filament data from MagnetSetFromGeometry() and updating the radial distance utilities so it will work with both subclasses seems to make sense from a separation of concerns point of view.
The text was updated successfully, but these errors were encountered: