Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Radial Distance Utils to Work With Both Sub Classes of MagnetSet() #186

Open
Edgar-21 opened this issue Jan 21, 2025 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@Edgar-21
Copy link
Contributor

As noted in #182, the only thing the coil filament data is used for in MagnetSetFromGeometry() is so the radial distance utilities work with both subclasses. Removing the coil filament data from MagnetSetFromGeometry() and updating the radial distance utilities so it will work with both subclasses seems to make sense from a separation of concerns point of view.

@Edgar-21 Edgar-21 added the enhancement New feature or request label Jan 21, 2025
@Edgar-21 Edgar-21 self-assigned this Jan 21, 2025
@connoramoreno
Copy link
Collaborator

@Edgar-21 has this been addressed?

@Edgar-21
Copy link
Contributor Author

Edgar-21 commented Feb 21, 2025

No I haven't started working on this yet, it also might not be necessary since if a user has the filament data to generate the surface we fire rays at they could just use MagnetSetFromFilaments() if they need to do radial distance finding. At the time I made this issue I felt that both classes should work with all parts of parastell but maybe that isn't the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants