-
Notifications
You must be signed in to change notification settings - Fork 57
chore(desktop): bump version to 0.0.49 #664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughBumps the desktop application package version from 0.0.48 to 0.0.49 in the package.json configuration file. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @apps/desktop/package.json:
- Line 5: Update the MINIMUM_DESKTOP_VERSION constant (currently "0.0.48") to
"0.0.49" in the desktop version route code (the constant named
MINIMUM_DESKTOP_VERSION), so it matches the bumped package.json version and
avoids API compatibility mismatches.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/desktop/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Build
- GitHub Check: Build - macOS (arm64)
| "productName": "Superset", | ||
| "description": "The last developer tool you'll ever need", | ||
| "version": "0.0.48", | ||
| "version": "0.0.49", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check for version consistency across the monorepo
# Search for all package.json files and their versions
echo "=== Package.json files with version fields ==="
fd -e json package.json --exec jq -r '.name as $name | .version as $version | if $version then "\($name // "unknown"): \($version)" else empty end' {} \;
# Search for potential hardcoded version references to 0.0.48
echo -e "\n=== Potential references to old version 0.0.48 ==="
rg "0\.0\.48" --type-add 'config:*.{json,ts,js,yml,yaml}' -t config 2>/dev/null || echo "No matches found"
# Search for other 0.0.x version patterns
echo -e "\n=== All 0.0.x version patterns in config files ==="
rg "0\.0\.\d+" --type-add 'config:*.{json,ts,js,yml,yaml}' -t config 2>/dev/null || echo "No matches found"
# Search for version exports or constants
echo -e "\n=== Version constants in code ==="
rg "version.*=.*['\"]0\.0\." --type ts --type js -C 1 2>/dev/null || echo "No matches found"Repository: superset-sh/superset
Length of output: 3577
Update MINIMUM_DESKTOP_VERSION constant to match the new version.
The version bump in apps/desktop/package.json is correct (0.0.48 → 0.0.49), but the hardcoded minimum version constant in apps/api/src/app/api/desktop/version/route.ts still references the old version:
const MINIMUM_DESKTOP_VERSION = "0.0.48";
This needs to be updated to "0.0.49" to maintain version consistency and prevent API compatibility issues.
🤖 Prompt for AI Agents
In @apps/desktop/package.json at line 5, Update the MINIMUM_DESKTOP_VERSION
constant (currently "0.0.48") to "0.0.49" in the desktop version route code (the
constant named MINIMUM_DESKTOP_VERSION), so it matches the bumped package.json
version and avoids API compatibility mismatches.
🧹 Preview Cleanup CompleteThe following preview resources have been cleaned up:
Thank you for your contribution! 🎉 |
Bumps desktop app version to 0.0.49.
This PR was automatically created by the release script.
Summary by CodeRabbit
Note: This release contains no new features or bug fixes.
✏️ Tip: You can customize this high-level summary in your review settings.