fix(auth): code verifier remains in storage during edge cases

Author: j4w8n

packages/core/auth-js/src/GoTrueClient.ts

@@ -572,6 +572,7 @@ export default class GoTrueClient {
       const { data, error } = res
 
       if (error || !data) {
+        await removeItemAsync(this.storage, `${this.storageKey}-code-verifier`)
         return { data: { user: null, session: null }, error: error }
       }
 
@@ -585,6 +586,7 @@ export default class GoTrueClient {
 
       return { data: { user, session }, error: null }
     } catch (error) {
+      await removeItemAsync(this.storage, `${this.storageKey}-code-verifier`)
       if (isAuthError(error)) {
         return { data: { user: null, session: null }, error }
       }
@@ -1186,6 +1188,7 @@ export default class GoTrueClient {
       }
       throw new AuthInvalidCredentialsError('You must provide either an email or phone number.')
     } catch (error) {
+      await removeItemAsync(this.storage, `${this.storageKey}-code-verifier`)
       if (isAuthError(error)) {
         return { data: { user: null, session: null }, error }
       }
@@ -1285,6 +1288,7 @@ export default class GoTrueClient {
         xform: _ssoResponse,
       })
     } catch (error) {
+      await removeItemAsync(this.storage, `${this.storageKey}-code-verifier`)
       if (isAuthError(error)) {
         return { data: null, error }
       }
@@ -1741,6 +1745,7 @@ export default class GoTrueClient {
         return { data: { user: session.user }, error: null }
       })
     } catch (error) {
+      await removeItemAsync(this.storage, `${this.storageKey}-code-verifier`)
       if (isAuthError(error)) {
         return { data: { user: null }, error }
       }
@@ -2193,6 +2198,7 @@ export default class GoTrueClient {
         redirectTo: options.redirectTo,
       })
     } catch (error) {
+      await removeItemAsync(this.storage, `${this.storageKey}-code-verifier`)
       if (isAuthError(error)) {
         return { data: null, error }
       }
@@ -2319,6 +2325,7 @@ export default class GoTrueClient {
         }
         return { data, error }
       } catch (error) {
+        await removeItemAsync(this.storage, `${this.storageKey}-code-verifier`)
         if (isAuthError(error)) {
           return { data: { user: null, session: null }, error }
         }