chore: fix AIO signal handling; propagate exit signal to all child process

Author: pcnc

.github/workflows/dockerhub-release-aio.yml

@@ -4,6 +4,7 @@ on:
   push:
     branches:
       - develop
+      - pcnc/fix-aio-signal-handling
     paths:
       - ".github/workflows/dockerhub-release-aio.yml"
       - "docker/all-in-one/*"

docker/all-in-one/Dockerfile

@@ -146,6 +146,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
     less \
     libnuma1 \
     logrotate \
+    dumb-init \
     # pg_egress_collect deps
     tcpdump libio-async-perl \
     && rm -rf /var/lib/apt/lists/* /tmp/* \
@@ -283,4 +284,6 @@ COPY docker/all-in-one/postgres-entrypoint.sh /usr/local/bin/
 COPY docker/all-in-one/shutdown.sh /usr/local/bin/supa-shutdown.sh
 COPY docker/all-in-one/run-logrotate.sh /usr/local/bin/run-logrotate.sh
 
-ENTRYPOINT [ "entrypoint.sh" ]
+ENTRYPOINT [ "/usr/bin/dumb-init" ]
+
+CMD [ "entrypoint.sh"]

docker/all-in-one/entrypoint.sh

@@ -63,14 +63,11 @@ function push_lsn_checkpoint_file {
 
 function graceful_shutdown {
   echo "$(date): Received SIGINT. Shutting down."
-  supervisorctl stop postgresql
 
   # Postgres ships the latest WAL file using archive_command during shutdown, in a blocking operation
   # This is to ensure that the WAL file is shipped, just in case
   sleep 0.2
   push_lsn_checkpoint_file
-
-  kill -s TERM "$(supervisorctl pid)"
 }
 
 function enable_autoshutdown {
@@ -188,6 +185,12 @@ function start_supervisor {
 
   # Start supervisord
   /usr/bin/supervisord -c $SUPERVISOR_CONF
+
+  # SUPERVISORD_PID=$(supervisorctl pid)
+
+  # while [ -e "/proc/$SUPERVISORD_PID" ]; do
+  #   sleep 5
+  # done
 }
 
 # Increase max number of open connections