Skip to content

Commit 2f0626f

Browse files
committed
fix: error when changing type & default at once
1 parent f49a87b commit 2f0626f

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

docker-compose.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
version: "3"
33
services:
44
db:
5-
image: supabase/postgres
5+
image: supabase/postgres:0.14.0
66
ports:
77
- "5432:5432"
88
volumes:

src/api/columns.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,13 +262,14 @@ const alterColumnSqlize = (
262262
: format('COMMENT ON COLUMN %I.%I.%I IS %L;', old.schema, old.table, old.name, comment)
263263

264264
// nameSql must be last.
265+
// defaultValueSql must be after typeSql.
265266
// TODO: Can't set default if column is previously identity even if is_identity: false.
266267
// Must do two separate PATCHes (once to drop identity and another to set default).
267268
return `
268269
BEGIN;
269270
${isNullableSql}
270-
${defaultValueSql}
271271
${typeSql}
272+
${defaultValueSql}
272273
${identitySql}
273274
${commentSql}
274275
${nameSql}

test/integration/index.spec.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ describe('/config/version', () => {
8888
const res = await axios.get(`${URL}/config/version`)
8989
// console.log('res.data', res.data)
9090
assert.equal(res.status, STATUS.SUCCESS)
91-
assert.equal(true, res.data.version_number == '120003')
91+
assert.equal(res.data.version_number, '120005')
9292
})
9393
})
9494
describe('/schemas', () => {
@@ -416,6 +416,7 @@ describe('/tables', async () => {
416416

417417
const { data: updatedColumn } = await axios.patch(`${URL}/columns/${newTable.id}.1`, {
418418
type: 'int4',
419+
default_value: 0
419420
})
420421

421422
assert.strictEqual(updatedColumn.format, 'int4')

0 commit comments

Comments
 (0)