Does not build against latest curl (8.16.0)

[draescherl]

Chore

Describe the chore

As the title suggests, compiling pg_net with curl 8.16.0 fails.

Additional context

Output of curl --version:

curl 8.16.0 (x86_64-pc-linux-gnu) libcurl/8.16.0 OpenSSL/3.5.3 zlib/1.3.1 brotli/1.1.0 zstd/1.5.7 libidn2/2.3.8 libssh2/1.11.1 nghttp2/1.67.1
Release-Date: 2025-09-10
Protocols: dict file ftp ftps gopher gophers http https imap imaps pop3 pop3s rtsp scp sftp smtp smtps telnet tftp ws wss
Features: AsynchDNS brotli HTTP2 HTTPS-proxy IDN IPv6 Largefile libz SSL threadsafe TLS-SRP UnixSockets zstd

Output of make:

x86_64-pc-linux-gnu-cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -march=native -O2 -pipe -std=c11 -Wextra -Wall -Werror -Wno-declaration-after-statement -Wno-vla -Wno-long-long -fPIC -fvisibility=hidden  -DEXTVERSION=\"0.19.7\" -I. -I./ -I/usr/x86_64-pc-linux-gnu/include/postgresql-18/server -I/usr/x86_64-pc-linux-gnu/include/postgresql-18/internal -march=native -O2 -pipe -D_GNU_SOURCE  -I/usr/x86_64-pc-linux-gnu/include/libxml2 -I/usr/local/include     -c -o src/core.o src/core.c
x86_64-pc-linux-gnu-cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -march=native -O2 -pipe -std=c11 -Wextra -Wall -Werror -Wno-declaration-after-statement -Wno-vla -Wno-long-long -fPIC -fvisibility=hidden  -DEXTVERSION=\"0.19.7\" -I. -I./ -I/usr/x86_64-pc-linux-gnu/include/postgresql-18/server -I/usr/x86_64-pc-linux-gnu/include/postgresql-18/internal -march=native -O2 -pipe -D_GNU_SOURCE  -I/usr/x86_64-pc-linux-gnu/include/libxml2 -I/usr/local/include     -c -o src/errors.o src/errors.c
x86_64-pc-linux-gnu-cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -march=native -O2 -pipe -std=c11 -Wextra -Wall -Werror -Wno-declaration-after-statement -Wno-vla -Wno-long-long -fPIC -fvisibility=hidden  -DEXTVERSION=\"0.19.7\" -I. -I./ -I/usr/x86_64-pc-linux-gnu/include/postgresql-18/server -I/usr/x86_64-pc-linux-gnu/include/postgresql-18/internal -march=native -O2 -pipe -D_GNU_SOURCE  -I/usr/x86_64-pc-linux-gnu/include/libxml2 -I/usr/local/include     -c -o src/event.o src/event.c
In file included from /usr/x86_64-pc-linux-gnu/include/curl/curl.h:3333,
                 from /usr/x86_64-pc-linux-gnu/include/curl/multi.h:51,
                 from src/event.h:4,
                 from src/event.c:6:
/usr/x86_64-pc-linux-gnu/include/curl/multi.h:423:23: error: expected identifier or '(' before '__extension__'
  423 | CURL_EXTERN CURLMcode curl_multi_setopt(CURLM *multi_handle,
      |                       ^~~~~~~~~~~~~~~~~
/usr/x86_64-pc-linux-gnu/include/curl/multi.h:423:23: error: expected identifier or '(' before ')' token
  423 | CURL_EXTERN CURLMcode curl_multi_setopt(CURLM *multi_handle,
      |                       ^~~~~~~~~~~~~~~~~
make: *** [<builtin>: src/event.o] Error 1

[steve-chavez]

Thanks for reporting, looks like curl 8.16.0 is quite new.

Tracking it in nixpkgs:

• Added here curlMinimal: 8.14.1 -> 8.16.0 NixOS/nixpkgs#425701
• We'll also need curlWithGnuTls curlMinimal: disable ca-fallback for gnutls NixOS/nixpkgs#444638