Binding to IPv6 ports prevents start

[BenIsenstein]

Bug report

• I confirm this is a bug with Supabase, not with my own application.
• I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

The edge runtime server fails to run when receiving an IPv6 host from the --ip option. Ex. "::", "::1"
The error logged is Error: invalid IPv4 address syntax

To Reproduce

git clone https://github.com/BenIsenstein/supabase-edge-runtime-ipv6-bug && \
cd supabase-edge-runtime-ipv6-bug && \
docker build -t supabase-edge-runtime-ipv6-bug . && \
docker run -p 9000:9000 supabase-edge-runtime-ipv6-bug

Expected behavior

The server is able to run listening for IPv6 connections.

Screenshots

No screenshots.

System information

• OS: MacOS working in Docker
• Edge Runtime Version: v1.67.4

Additional context

None

[kallebysantos]

Hi guys 💚

I confirm that I was able to reproduce the error, tested both from the instructions provided by @BenIsenstein as well by running directly from source code with ./scripts/run.sh

Logs

Running from the code snippet provided by the author

Error: Error: invalid IPv4 address syntax, probably handled from Js land

❯ git clone https://github.com/BenIsenstein/supabase-edge-runtime-ipv6-bug && \
      cd supabase-edge-runtime-ipv6-bug && \
      docker build -t supabase-edge-runtime-ipv6-bug . && \
      docker run -p 9000:9000 supabase-edge-runtime-ipv6-bug
Cloning into 'supabase-edge-runtime-ipv6-bug'...
remote: Enumerating objects: 9, done.
remote: Counting objects: 100% (9/9), done.
remote: Compressing objects: 100% (7/7), done.
remote: Total 9 (delta 0), reused 9 (delta 0), pack-reused 0 (from 0)
Receiving objects: 100% (9/9), done.
[+] Building 0.8s (7/7) FINISHED                                                                                                                                                                     docker:orbstack
 => [internal] load build definition from Dockerfile                                                                                                                                                            0.1s
 => => transferring dockerfile: 225B                                                                                                                                                                            0.0s
 => [internal] load metadata for docker.io/supabase/edge-runtime:v1.67.4                                                                                                                                        0.0s
 => [internal] load .dockerignore                                                                                                                                                                               0.0s
 => => transferring context: 2B                                                                                                                                                                                 0.0s
 => [internal] load build context                                                                                                                                                                               0.1s
 => => transferring context: 3.57kB                                                                                                                                                                             0.0s
 => [1/2] FROM docker.io/supabase/edge-runtime:v1.67.4                                                                                                                                                          0.2s
 => [2/2] COPY ./functions /home/deno/functions                                                                                                                                                                 0.2s
 => exporting to image                                                                                                                                                                                          0.1s
 => => exporting layers                                                                                                                                                                                         0.0s
 => => writing image sha256:0c4a4f460bd0a47028abcadf7326855769fe0f1a4135e386cbdf7cb530a38c55                                                                                                                    0.0s
 => => naming to docker.io/library/supabase-edge-runtime-ipv6-bug                                                                                                                                               0.0s

View build details: docker-desktop://dashboard/build/orbstack/orbstack/pgeujffk79cy78bwzv8zzaw79
Download https://deno.land/std@0.131.0/http/server.ts
Download https://deno.land/x/jose@v4.14.4/index.ts
Download https://deno.land/std@0.131.0/async/mod.ts
Download https://deno.land/x/jose@v4.14.4/jwe/compact/decrypt.ts
Download https://deno.land/x/jose@v4.14.4/jwe/flattened/decrypt.ts
Download https://deno.land/x/jose@v4.14.4/jwe/general/decrypt.ts
Download https://deno.land/x/jose@v4.14.4/jwe/general/encrypt.ts
Download https://deno.land/x/jose@v4.14.4/jws/compact/verify.ts
Download https://deno.land/x/jose@v4.14.4/jws/flattened/verify.ts
Download https://deno.land/x/jose@v4.14.4/jws/general/verify.ts
Download https://deno.land/x/jose@v4.14.4/jwt/verify.ts
Download https://deno.land/x/jose@v4.14.4/jwt/decrypt.ts
Download https://deno.land/x/jose@v4.14.4/jwe/compact/encrypt.ts
Download https://deno.land/x/jose@v4.14.4/jwe/flattened/encrypt.ts
Download https://deno.land/x/jose@v4.14.4/jws/compact/sign.ts
Download https://deno.land/x/jose@v4.14.4/jws/flattened/sign.ts
Download https://deno.land/x/jose@v4.14.4/jws/general/sign.ts
Download https://deno.land/x/jose@v4.14.4/jwt/sign.ts
Download https://deno.land/x/jose@v4.14.4/jwt/encrypt.ts
Download https://deno.land/x/jose@v4.14.4/jwk/thumbprint.ts
Download https://deno.land/x/jose@v4.14.4/jwk/embedded.ts
Download https://deno.land/x/jose@v4.14.4/jwks/local.ts
Download https://deno.land/x/jose@v4.14.4/jwks/remote.ts
Download https://deno.land/x/jose@v4.14.4/jwt/unsecured.ts
Download https://deno.land/x/jose@v4.14.4/key/export.ts
Download https://deno.land/x/jose@v4.14.4/key/import.ts
Download https://deno.land/x/jose@v4.14.4/util/decode_protected_header.ts
Download https://deno.land/x/jose@v4.14.4/util/decode_jwt.ts
Download https://deno.land/x/jose@v4.14.4/util/errors.ts
Download https://deno.land/x/jose@v4.14.4/key/generate_key_pair.ts
Download https://deno.land/x/jose@v4.14.4/key/generate_secret.ts
Download https://deno.land/x/jose@v4.14.4/util/base64url.ts
Download https://deno.land/std@0.131.0/async/abortable.ts
Download https://deno.land/std@0.131.0/async/deadline.ts
Download https://deno.land/std@0.131.0/async/debounce.ts
Download https://deno.land/std@0.131.0/async/deferred.ts
Download https://deno.land/std@0.131.0/async/delay.ts
Download https://deno.land/std@0.131.0/async/mux_async_iterator.ts
Download https://deno.land/std@0.131.0/async/pool.ts
Download https://deno.land/std@0.131.0/async/tee.ts
Download https://deno.land/x/jose@v4.14.4/lib/buffer_utils.ts
Download https://deno.land/x/jose@v4.14.4/runtime/base64url.ts
Download https://deno.land/x/jose@v4.14.4/runtime/decrypt.ts
Download https://deno.land/x/jose@v4.14.4/runtime/zlib.ts
Download https://deno.land/x/jose@v4.14.4/lib/is_disjoint.ts
Download https://deno.land/x/jose@v4.14.4/lib/is_object.ts
Download https://deno.land/x/jose@v4.14.4/lib/decrypt_key_management.ts
Download https://deno.land/x/jose@v4.14.4/lib/cek.ts
Download https://deno.land/x/jose@v4.14.4/lib/validate_crit.ts
Download https://deno.land/x/jose@v4.14.4/lib/validate_algorithms.ts
Download https://deno.land/x/jose@v4.14.4/lib/encrypt_key_management.ts
Download https://deno.land/x/jose@v4.14.4/runtime/verify.ts
Download https://deno.land/x/jose@v4.14.4/lib/check_key_type.ts
Download https://deno.land/x/jose@v4.14.4/lib/jwt_claims_set.ts
Download https://deno.land/x/jose@v4.14.4/runtime/encrypt.ts
Download https://deno.land/x/jose@v4.14.4/lib/iv.ts
Download https://deno.land/x/jose@v4.14.4/runtime/sign.ts
Download https://deno.land/x/jose@v4.14.4/jwt/produce.ts
Download https://deno.land/x/jose@v4.14.4/runtime/digest.ts
Download https://deno.land/x/jose@v4.14.4/runtime/fetch_jwks.ts
Download https://deno.land/x/jose@v4.14.4/runtime/asn1.ts
Download https://deno.land/x/jose@v4.14.4/runtime/key_to_jwk.ts
Download https://deno.land/x/jose@v4.14.4/runtime/jwk_to_key.ts
Download https://deno.land/x/jose@v4.14.4/runtime/generate.ts
Download https://deno.land/x/jose@v4.14.4/lib/check_iv_length.ts
Download https://deno.land/x/jose@v4.14.4/runtime/check_cek_length.ts
Download https://deno.land/x/jose@v4.14.4/runtime/timing_safe_equal.ts
Download https://deno.land/x/jose@v4.14.4/runtime/webcrypto.ts
Download https://deno.land/x/jose@v4.14.4/lib/crypto_key.ts
Download https://deno.land/x/jose@v4.14.4/lib/invalid_key_input.ts
Download https://deno.land/x/jose@v4.14.4/runtime/is_key_like.ts
Download https://deno.land/x/jose@v4.14.4/runtime/aeskw.ts
Download https://deno.land/x/jose@v4.14.4/runtime/ecdhes.ts
Download https://deno.land/x/jose@v4.14.4/runtime/pbes2kw.ts
Download https://deno.land/x/jose@v4.14.4/runtime/rsaes.ts
Download https://deno.land/x/jose@v4.14.4/lib/aesgcmkw.ts
Download https://deno.land/x/jose@v4.14.4/runtime/random.ts
Download https://deno.land/x/jose@v4.14.4/runtime/subtle_dsa.ts
Download https://deno.land/x/jose@v4.14.4/runtime/check_key_length.ts
Download https://deno.land/x/jose@v4.14.4/runtime/get_sign_verify_key.ts
Download https://deno.land/x/jose@v4.14.4/lib/epoch.ts
Download https://deno.land/x/jose@v4.14.4/lib/secs.ts
Download https://deno.land/x/jose@v4.14.4/lib/format_pem.ts
Download https://deno.land/x/jose@v4.14.4/runtime/bogus.ts
Download https://deno.land/x/jose@v4.14.4/lib/check_p2s.ts
Download https://deno.land/x/jose@v4.14.4/runtime/subtle_rsaes.ts
Error: invalid IPv4 address syntax
main function started

Running from source code

Error: invalid socket address syntax, happens here - Seems that &format!("{ip}:{port}" syntax doesn't apply for IPv6 addresses

❯ cargo build --features cli/tracing &&
  RUST_BACKTRACE=full ./target/debug/edge-runtime start \
    --ip "::1" \
    --main-service ./examples/main \
    --event-worker ./examples/event-manager

Error: failed to parse the address to bind the server

Caused by:
    invalid socket address syntax

Stack backtrace:
   0: std::backtrace_rs::backtrace::libunwind::trace
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/../../backtrace/src/backtrace/libunwind.rs:116:5
   1: std::backtrace_rs::backtrace::trace_unsynchronized
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
   2: std::backtrace::Backtrace::create
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/backtrace.rs:331:13
   3: <E as anyhow::context::ext::StdError>::ext_context
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.83/src/backtrace.rs:27:14
   4: anyhow::context::<impl anyhow::Context<T,E> for core::result::Result<T,E>>::context
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.83/src/context.rs:54:31
   5: edge_runtime::main::{{closure}}
             at ./cli/src/main.rs:83:20
   6: <tokio::task::local::RunUntil<T> as core::future::future::Future>::poll::{{closure}}
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/task/local.rs:978:42
   7: tokio::task::local::LocalSet::with::{{closure}}
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/task/local.rs:730:13
   8: std::thread::local::LocalKey<T>::try_with
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/thread/local.rs:283:12
   9: std::thread::local::LocalKey<T>::with
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/thread/local.rs:260:9
  10: tokio::task::local::LocalSet::with
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/task/local.rs:728:9
  11: <tokio::task::local::RunUntil<T> as core::future::future::Future>::poll
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/task/local.rs:968:9
  12: tokio::task::local::LocalSet::run_until::{{closure}}
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/task/local.rs:635:19
  13: <core::pin::Pin<P> as core::future::future::Future>::poll
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/future/future.rs:123:9
  14: tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}::{{closure}}::{{closure}}
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:659:57
  15: tokio::runtime::coop::with_budget
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/coop.rs:107:5
  16: tokio::runtime::coop::budget
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/coop.rs:73:5
  17: tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}::{{closure}}
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:659:25
  18: tokio::runtime::scheduler::current_thread::Context::enter
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:404:19
  19: tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:658:36
  20: tokio::runtime::scheduler::current_thread::CoreGuard::enter::{{closure}}
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:737:68
  21: tokio::runtime::context::scoped::Scoped<T>::set
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/context/scoped.rs:40:9
  22: tokio::runtime::context::set_scheduler::{{closure}}
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/context.rs:176:26
  23: std::thread::local::LocalKey<T>::try_with
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/thread/local.rs:283:12
  24: std::thread::local::LocalKey<T>::with
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/thread/local.rs:260:9
  25: tokio::runtime::context::set_scheduler
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/context.rs:176:9
  26: tokio::runtime::scheduler::current_thread::CoreGuard::enter
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:737:27
  27: tokio::runtime::scheduler::current_thread::CoreGuard::block_on
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:646:19
  28: tokio::runtime::scheduler::current_thread::CurrentThread::block_on::{{closure}}
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:175:28
  29: tokio::runtime::context::runtime::enter_runtime
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/context/runtime.rs:65:16
  30: tokio::runtime::scheduler::current_thread::CurrentThread::block_on
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/scheduler/current_thread/mod.rs:167:9
  31: tokio::runtime::runtime::Runtime::block_on
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/runtime/runtime.rs:348:47
  32: tokio::task::local::LocalSet::block_on
             at /Users/kallebysantos/.cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.36.0/src/task/local.rs:592:9
  33: edge_runtime::main
             at ./cli/src/main.rs:49:38
  34: core::ops::function::FnOnce::call_once
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/ops/function.rs:250:5
  35: std::sys::backtrace::__rust_begin_short_backtrace
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/sys/backtrace.rs:154:18
  36: std::rt::lang_start::{{closure}}
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/rt.rs:164:18
  37: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/ops/function.rs:284:13
  38: std::panicking::try::do_call
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panicking.rs:554:40
  39: std::panicking::try
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panicking.rs:518:19
  40: std::panic::catch_unwind
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panic.rs:345:14
  41: std::rt::lang_start_internal::{{closure}}
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/rt.rs:143:48
  42: std::panicking::try::do_call
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panicking.rs:554:40
  43: std::panicking::try
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panicking.rs:518:19
  44: std::panic::catch_unwind
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panic.rs:345:14
  45: std::rt::lang_start_internal
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/rt.rs:143:20
  46: std::rt::lang_start
             at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/rt.rs:163:17
  47: _main

---

I believe that it happens here - Seems that &format!("{ip}:{port}" syntax doesn't apply for IPv6 addresses.

[kallebysantos]

I took the opportunity to push a patch fix for it #547 💚

result