updated tests to ignore internal schemas and removed unused sql queries

Author: encima

cmd/inspect.go

@@ -224,11 +224,11 @@ func printReportSummary(outDir string) error {
 	table := "RULE|STATUS|MATCHES\n|-|-|-|\n"
 
 	// find matching rule
-
+	var status string
 	for i := range cfg.Rules {
 		r := &cfg.Rules[i]
 		name := r.Name
-		status := "--"
+
 		row := db.QueryRow(r.Query)
 		var match sql.NullString
 

internal/inspect/db_stats/db_stats_test.go

@@ -7,8 +7,6 @@ import (
 	"github.com/jackc/pgconn"
 	"github.com/spf13/afero"
 	"github.com/stretchr/testify/assert"
-	"github.com/supabase/cli/internal/db/reset"
-	"github.com/supabase/cli/internal/utils"
 	"github.com/supabase/cli/pkg/pgtest"
 )
 
@@ -27,7 +25,7 @@ func TestDBStatsCommand(t *testing.T) {
 		// Setup mock postgres
 		conn := pgtest.NewConn()
 		defer conn.Close(t)
-		conn.Query(DBStatsQuery, reset.LikeEscapeSchema(utils.InternalSchemas)).
+		conn.Query(DBStatsQuery).
 			Reply("SELECT 1", Result{
 				Database_size:          "8GB",
 				Total_index_size:       "8GB",

internal/inspect/index_stats/index_stats_test.go

@@ -27,7 +27,7 @@ func TestIndexStatsCommand(t *testing.T) {
 		defer conn.Close(t)
 
 		// Mock index stats
-		conn.Query(IndexStatsQuery, reset.LikeEscapeSchema(utils.PgSchemas)).
+		conn.Query(IndexStatsQuery, reset.LikeEscapeSchema(utils.InternalSchemas)).
 			Reply("SELECT 1", Result{
 				Name:         "public.test_idx",
 				Size:         "1GB",

internal/inspect/seq_scans/seq_scans.sql

@@ -27,7 +27,7 @@ func TestTableStatsCommand(t *testing.T) {
 		defer conn.Close(t)
 
 		// Mock table sizes and index sizes
-		conn.Query(TableStatsQuery, reset.LikeEscapeSchema(utils.PgSchemas)).
+		conn.Query(TableStatsQuery, reset.LikeEscapeSchema(utils.InternalSchemas)).
 			Reply("SELECT 1", Result{
 				Name:                "public.test_table",
 				Table_size:          "3GB",

internal/inspect/table_index_sizes/table_index_sizes.sql

@@ -29,7 +29,7 @@ func Run(ctx context.Context, config pgconn.Config, fsys afero.Fs, options ...fu
 		return err
 	}
 	defer conn.Close(context.Background())
-	rows, err := conn.Query(ctx, TotalTableSizesQuery, reset.LikeEscapeSchema(utils.PgSchemas))
+	rows, err := conn.Query(ctx, TotalTableSizesQuery, reset.LikeEscapeSchema(utils.InternalSchemas))
 	if err != nil {
 		return errors.Errorf("failed to query rows: %w", err)
 	}

internal/inspect/table_record_counts/table_record_counts.sql

@@ -27,7 +27,7 @@ func TestTotalTableSizesCommand(t *testing.T) {
 		// Setup mock postgres
 		conn := pgtest.NewConn()
 		defer conn.Close(t)
-		conn.Query(TotalTableSizesQuery, reset.LikeEscapeSchema(utils.PgSchemas)).
+		conn.Query(TotalTableSizesQuery, reset.LikeEscapeSchema(utils.InternalSchemas)).
 			Reply("SELECT 1", Result{
 				Name: "public.test_table",
 				Size: "3GB",