Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Djoser 2.1.0 dependencies #594

Open
Viitainen opened this issue Mar 2, 2021 · 2 comments · May be fixed by #782
Open

Djoser 2.1.0 dependencies #594

Viitainen opened this issue Mar 2, 2021 · 2 comments · May be fixed by #782

Comments

@Viitainen
Copy link

Installing Djoser 2.1.0 through pip seems to also install djangorestframework-simplejwt, social-auth-app-django, coreapi etc. by default. The documentation states that these should (can) be installed only when needed. Those two packages seem to have quite a bit of dependencies as well which are causing some installation problems on our Docker-container.

It seems that the change happened between 2.0.5 and 2.1.0 versions when you removed the setup.py and requirements.txt and moved to use poetry and pyproject.toml. I think previously only the django-templated-mail was pretty much the only one needed.

Is the documentation just outdated and you made those packages part of the required dependencies, or? Maybe I'm just missing something, I'm not used to the Python, pip etc.

@khashashin
Copy link
Contributor

I'm happy that I saw this issue before djoser upgrade

@allanlewis
Copy link
Contributor

Presumably the optional dependencies can be included using setuptools' "extras" mechanism?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants