🚨(backend) various fixes

I am fixing various things

Signed-off-by: charles <charles.englebert@protonmail.com>

Author: mascarpon3

README.md

@@ -147,8 +147,9 @@ $ make frontend-test
 $ make frontend-lint
 ```
 
-Backend tests can be run without docker by settings Path to ".env" file to 
-`env.d/development/common.test`
+Backend tests can be run without docker with the env files
+`env.d/development/common` and `env.d/development/common.test`.
+`common.test` must overwrite some variables in `common`.
 
 **Adding content**
 

src/backend/core/api/serializers.py

@@ -980,5 +980,5 @@ def get_abilities(self, thread):
 class SearchDocumentSerializer(serializers.Serializer):
     """Serializer for fulltext search requests through Find application"""
 
-    q = serializers.CharField(required=True, allow_blank=False, trim_whitespace=True)
+    q = serializers.CharField(required=True, allow_blank=True, trim_whitespace=True)
     path = serializers.CharField(required=False, allow_blank=False)

src/backend/core/api/viewsets.py

@@ -1165,7 +1165,6 @@ def duplicate(self, request, *args, **kwargs):
             {"id": str(duplicated_document.id)}, status=status.HTTP_201_CREATED
         )
 
-
     @drf.decorators.action(detail=False, methods=["get"], url_path="search")
     @method_decorator(refresh_oidc_access_token)
     def search(self, request, *args, **kwargs):
@@ -1218,12 +1217,15 @@ def _search_with_indexer(indexer, request, params):
         )
 
     def title_search(self, request, validated_data, *args, **kwargs):
+        """
+        Fallback search by title when indexer is not configured.
+        If path is provided, list descendants, otherwise list all documents.
+        """
         request.GET = request.GET.copy()
-        request.GET['title'] = validated_data['q']
-        if not "path" in validated_data or not validated_data["path"]:
+        request.GET["title"] = validated_data["q"]
+        if not "path" in request.GET or not request.GET["path"]:
             return self.list(request, *args, **kwargs)
-        else:
-            return self._list_descendants(request)
+        return self._list_descendants(request)
 
     def _list_descendants(self, request):
         """
@@ -1236,15 +1238,17 @@ def _list_descendants(self, request):
         try:
             parent = models.Document.objects.get(path=parent_path)
         except models.Document.DoesNotExist as exc:
-            raise drf.exceptions.NotFound("Document not found from path %s.", parent_path) from exc
+            raise drf.exceptions.NotFound("Document not found from path.") from exc
 
         # Check object-level permissions using DocumentPermission logic
         self.check_object_permissions(request, parent)
 
         # Get descendants and include the parent, ordered by path
-        queryset = parent.get_descendants(include_self=True).filter(
-            ancestors_deleted_at__isnull=True
-        ).order_by("path")
+        queryset = (
+            parent.get_descendants(include_self=True)
+            .filter(ancestors_deleted_at__isnull=True)
+            .order_by("path")
+        )
         queryset = self.filter_queryset(queryset)
 
         # filter by title
@@ -1255,7 +1259,6 @@ def _list_descendants(self, request):
         queryset = filterset.qs
         return self.get_response_for_queryset(queryset)
 
-
     @drf.decorators.action(detail=True, methods=["get"], url_path="versions")
     def versions_list(self, request, *args, **kwargs):
         """

src/backend/core/services/search_indexers.py

@@ -8,7 +8,6 @@
 from django.conf import settings
 from django.contrib.auth.models import AnonymousUser
 from django.core.exceptions import ImproperlyConfigured
-from django.db.models import Subquery
 from django.utils.module_loading import import_string
 
 import requests
@@ -78,15 +77,17 @@ def get_visited_document_ids_of(queryset, user):
     if isinstance(user, AnonymousUser):
         return []
 
-    qs = models.LinkTrace.objects.filter(user=user)
+    visited_ids = models.LinkTrace.objects.filter(user=user).values_list(
+        "document_id", flat=True
+    )
 
     docs = (
         queryset.exclude(accesses__user=user)
         .filter(
             deleted_at__isnull=True,
             ancestors_deleted_at__isnull=True,
         )
-        .filter(pk__in=Subquery(qs.values("document_id")))
+        .filter(pk__in=visited_ids)
         .order_by("pk")
         .distinct("pk")
     )
@@ -193,7 +194,7 @@ def search(self, q, token, visited=(), nb_results=None, path=None):
         Returns ids of the documents
 
         Args:
-            q (str): Text search content.
+            q (str): user query.
             token (str): OIDC Authentication token.
             visited (list, optional):
                 List of ids of active public documents with LinkTrace
@@ -202,7 +203,7 @@ def search(self, q, token, visited=(), nb_results=None, path=None):
                 The number of results to return.
                 Defaults to 50 if not specified.
             path (str, optional):
-                The path to filter documents.
+                The parent path to search descendants of.
         """
         nb_results = nb_results or self.search_limit
         results = self.search_query(
@@ -231,25 +232,27 @@ def search_query(self, data, token) -> dict:
 
 class FindDocumentIndexer(BaseDocumentIndexer):
     """
-    Document indexer that indexes and searches documents to La Suite Find app.
+    Document indexer that indexes and searches documents with La Suite Find app.
     """
 
+    # pylint: disable=too-many-arguments,too-many-positional-arguments
     def search(self, q, token, visited=(), nb_results=None, path=None):
         """format Find search results"""
         search_results = super().search(q, token, visited, nb_results, path)
         return [
             {
+                **hit["_source"],
                 "id": hit["_id"],
                 "title": self.get_title(hit["_source"]),
-                **hit["_source"],
             }
             for hit in search_results
         ]
 
     @staticmethod
     def get_title(source):
         """
-        Extract the title from a search result source dictionary.
+        Find returns the titles with an extension depending on the language.
+        This function extracts the title in a generic way.
 
         Handles multiple cases:
         - Localized title fields like "title.<some_extension>"
@@ -271,13 +274,12 @@ def get_title(source):
             ""
         """
         titles = utils.get_value_by_pattern(source, r"^title\.")
-        if titles:
-            title = titles[0]
-        elif "title" in source:
-            title = source["title"]
-        else:
-            title = ""
-        return title
+        for title in titles:
+            if title:
+                return title
+        if "title" in source:
+            return source["title"]
+        return ""
 
     def serialize_document(self, document, accesses):
         """