Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Dark Mode for Musicblocks #4195

Open
4 tasks done
retrogtx opened this issue Dec 28, 2024 · 5 comments · May be fixed by #4207
Open
4 tasks done

Feature Request: Dark Mode for Musicblocks #4195

retrogtx opened this issue Dec 28, 2024 · 5 comments · May be fixed by #4207

Comments

@retrogtx
Copy link
Contributor

Current Behavior

Currently, Musicblocks is light mode only.

Desired Behavior

We could add an optional dark mode, which will be pleasant for our eyes.

The dark mode isn't necessarily going to be applied to every component, but it just a dark background will do wonders as well.

Screenshots / Mockups

image

Implementation

Acceptance Tests

Environment

  • Operating System: [e.g., Windows, macOS, Linux]
  • Browser (if applicable): [e.g., Chrome, Firefox, Safari]
  • Version of Software/Project: [e.g., v1.0.0]

Additional Information

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.

Thank you for contributing to our project! We appreciate your help in improving it.

📚 See contributing instructions.

🙋🏾🙋🏼 Questions: Community Matrix Server.

@retrogtx retrogtx changed the title Dark Mode for Musicblocks Feature Request: Dark Mode for Musicblocks Dec 28, 2024
@omsuneri
Copy link
Contributor

@retrogtx i think you must discuss this with @walterbender as MB might be more beautiful in Dark mode as well

@retrogtx
Copy link
Contributor Author

yep absolutely, just look at the loading screen.

@Bishal77 Bishal77 linked a pull request Dec 29, 2024 that will close this issue
@walterbender
Copy link
Member

We should make a list of the places that still need attending to. I am not sure about the default background color for the canvas. But the various widget backgrounds should be updated to use platform styles. Maybe we need to move more of the style info to CSS

@Bishal77
Copy link

@walterbender could you elaborate more.

@walterbender
Copy link
Member

For example, the background of the help widget is still white. Where else do we have issues with hard-coded colors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants