Skip to content

Commit e16728f

Browse files
ctian1nhtyy
andauthored
chore: bump sp1, support arch override (#199)
* fix: remove programs feature, bump lockfiles * bump v4 * sm_86 * bump * arch env var * fix * sp1 public dev * use -gencode * remove rug * bump * fix --------- Co-authored-by: N <[email protected]>
1 parent 7c71b0e commit e16728f

File tree

9 files changed

+277
-329
lines changed

9 files changed

+277
-329
lines changed

Cargo.lock

Lines changed: 102 additions & 157 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,13 @@ debug-assertions = true
1919
[workspace.dependencies]
2020

2121
# sp1
22-
sp1-core-executor = { git = "https://github.com/succinctlabs/sp1-wip", branch = "dev", features = ["bigint-rug"] }
23-
sp1-core-machine = { git = "https://github.com/succinctlabs/sp1-wip", branch = "dev" }
24-
sp1-prover = { git = "https://github.com/succinctlabs/sp1-wip", branch = "dev" }
25-
sp1-recursion-core = { git = "https://github.com/succinctlabs/sp1-wip", branch = "dev" }
26-
sp1-cuda = { git = "https://github.com/succinctlabs/sp1-wip", branch = "dev" }
27-
sp1-stark = { git = "https://github.com/succinctlabs/sp1-wip", branch = "dev" }
28-
sp1-eval = { git = "https://github.com/succinctlabs/sp1-wip", branch = "dev" }
29-
test-artifacts = { git = "https://github.com/succinctlabs/sp1-wip", branch = "dev" }
22+
sp1-core-executor = { version = "4.1.0" }
23+
sp1-core-machine = { version = "4.1.0" }
24+
sp1-prover = { version = "4.1.0" }
25+
sp1-recursion-core = { version = "4.1.0" }
26+
sp1-cuda = { version = "4.1.0" }
27+
sp1-stark = { version = "4.1.0" }
28+
sp1-eval = { version = "4.1.0" }
3029

3130
# p3
3231
p3-interpolation = "=0.2.0-succinct"
@@ -52,15 +51,15 @@ p3-maybe-rayon = "=0.2.0-succinct"
5251
p3-bn254-fr = "=0.2.0-succinct"
5352

5453
# for local development
55-
# sp1-core-executor = { path = "../sp1-wip/crates/core/executor", features = [
54+
# sp1-core-executor = { path = "../sp1/crates/core/executor", features = [
5655
# "bigint-rug",
5756
# ] }
58-
# sp1-core-machine = { path = "../sp1-wip/crates/core/machine" }
59-
# sp1-prover = { path = "../sp1-wip/crates/prover", features = ["native-gnark"] }
60-
# sp1-recursion-core = { path = "../sp1-wip/crates/recursion/core" }
61-
# sp1-cuda = { path = "../sp1-wip/crates/cuda" }
62-
# sp1-stark = { path = "../sp1-wip/crates/stark" }
63-
# sp1-eval = { path = "../sp1-wip/crates/eval" }
57+
# sp1-core-machine = { path = "../sp1/crates/core/machine" }
58+
# sp1-prover = { path = "../sp1/crates/prover", features = ["native-gnark"] }
59+
# sp1-recursion-core = { path = "../sp1/crates/recursion/core" }
60+
# sp1-cuda = { path = "../sp1/crates/cuda" }
61+
# sp1-stark = { path = "../sp1/crates/stark" }
62+
# sp1-eval = { path = "../sp1/crates/eval" }
6463

6564
# p3-field = { path = "../Plonky3/field" }
6665
# p3-air = { path = "../Plonky3/air" }

core/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,5 +52,4 @@ ignore = "0.4.23"
5252
rand = "0.8.5"
5353
p3-fri = { workspace = true }
5454
p3-uni-stark = { workspace = true }
55-
test-artifacts = { workspace = true }
5655
serial_test = "3.1.1"

core/build.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,8 @@ fn main() {
186186
cc_builder.flag("-lnvToolsExt");
187187
cc_builder.flag("-ldl");
188188
cc_builder.flag("--expt-relaxed-constexpr");
189-
cc_builder.flag("-arch=sm_89");
189+
cc_builder.flag("-gencode=arch=compute_86,code=sm_86");
190+
cc_builder.flag("-gencode=arch=compute_89,code=sm_89");
190191

191192
env::set_var("DEP_SPPARK_ROOT", "../sppark");
192193
if let Some(include) = env::var_os("DEP_SPPARK_ROOT") {

core/src/stark/permutation.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -452,7 +452,9 @@ mod tests {
452452
use sp1_core_executor::Program;
453453
use sp1_core_machine::{memory::MemoryLocalChip, riscv::ByteChip};
454454
use sp1_stark::InteractionBuilder;
455-
use test_artifacts::FIBONACCI_ELF;
455+
456+
const FIBONACCI_ELF: &[u8] =
457+
include_bytes!("../../../perf/programs/fibonacci/riscv32im-succinct-zkvm-elf");
456458

457459
type F = BabyBear;
458460
const D: usize = 4;

core/src/stark/quotient.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,8 @@ mod tests {
329329

330330
use rand::thread_rng;
331331

332-
use test_artifacts::FIBONACCI_ELF;
332+
const FIBONACCI_ELF: &[u8] =
333+
include_bytes!("../../../perf/programs/fibonacci/riscv32im-succinct-zkvm-elf");
333334
use tracing::info;
334335

335336
use crate::{

core/src/utils/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ mod tracer;
44

55
#[allow(unused_imports)]
66
pub use nvtx::*;
7-
use sp1_core_executor::{ExecutionRecord, Executor, Program, Trace};
7+
use sp1_core_executor::{ExecutionRecord, Executor, Program};
88
use sp1_stark::SP1CoreOpts;
99
#[allow(unused_imports)]
1010
pub use tracer::*;
@@ -14,6 +14,6 @@ pub use stats::*;
1414
pub fn execute_core(program: Program) -> ExecutionRecord {
1515
let opts = SP1CoreOpts::default();
1616
let mut runtime = Executor::new(program, opts);
17-
runtime.run::<Trace>().unwrap();
17+
runtime.run().unwrap();
1818
*(runtime.record)
1919
}

prover/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ p3-field = { workspace = true }
2222
sp1-prover = { workspace = true }
2323
sp1-core-executor = { workspace = true }
2424
sp1-core-machine = { workspace = true }
25-
test-artifacts = { workspace = true }
2625
p3-baby-bear = { workspace = true }
2726
sp1-stark = { workspace = true }
2827
serial_test = "3.1.1"

0 commit comments

Comments
 (0)