powers of alpha device fix

Author: umadayal

core/src/stark/quotient.rs

@@ -114,6 +114,8 @@ where
             )
             .unwrap();
             quotient_flat.set_max_width();
+            let powers_of_folding_challenge_device =
+                powers_of_folding_challenge.to_device_async(stream).unwrap();
             quotient_gpu::compute_values(
                 operations_device.as_ptr(),
                 operations.len(),
@@ -128,7 +130,7 @@ where
                 main_evaluations.view(),
                 permutation_evaluations.view(),
                 permutation_challenges.as_ptr(),
-                powers_of_folding_challenge.as_ptr(),
+                powers_of_folding_challenge_device.as_ptr(),
                 public_values.as_ptr(),
                 trace_domain_generator,
                 quotient_domain_generator,

cuda/quotient/quotient.cuh

@@ -77,8 +77,8 @@ __global__ void computeValues(
     folder.isLastRow = isLastRow;
     folder.isTransition = isTransition;
     folder.powersOfAlpha = powersOfAlpha;
-    folder.accumulator = Challenge::zero();
     folder.constraintIndex = 0;
+    folder.accumulator = Challenge::zero();
     folder.quotientIdx = quotientIdx;
     folder.quotientSize = quotientSize;
     folder.nextStep = nextStep;
@@ -569,12 +569,12 @@ __global__ void computeValues(
 
             case 59:
                 DEBUG("FAssertZero: %d\n", instr.a);
-                folder.accumulator += folder.powersOfAlpha[folder.constraintIndex] * expr_f[instr.a];
+                folder.accumulator += (folder.powersOfAlpha[folder.constraintIndex] * expr_f[instr.a]);
                 folder.constraintIndex++;
                 break;
             case 60:
                 DEBUG("EAssertZero: %d\n", instr.a);
-                folder.accumulator += folder.powersOfAlpha[folder.constraintIndex] * expr_ef[instr.a];
+                folder.accumulator += (folder.powersOfAlpha[folder.constraintIndex] * expr_ef[instr.a]);
                 folder.constraintIndex++;
                 break;
         }